Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix refs #42

Closed
wants to merge 1 commit into from
Closed

fix refs #42

wants to merge 1 commit into from

Conversation

skatlapa
Copy link
Contributor

pr doesn't get recognized in Git Lab, changing to mr

@skatlapa
fix refs
83808a0 
pr doesn't get recognized in Git Lab, changing to mr
@skatlapa skatlapa requested a review from joejstuart March 12, 2019 21:46
@skatlapa
Copy link
Contributor Author

#41

@joejstuart
Copy link
Contributor

I don't know if this is the fix since it's referring to a github repo. I think the fix is to only have one ref spec entry in Jenkins.

@joejstuart
Copy link
Contributor

Updating "refspec" in the json to an array and then updating the data type in the init script should fix it. I haven't tested it though.

https://github.com/CentOS-PaaS-SIG/contra-env-infra/blob/master/jenkins/master/openshift/configuration/init.groovy.d/contra-global_variables.groovy#54

@joejstuart
Copy link
Contributor

This isn't needed anymore so closing

@joejstuart joejstuart closed this May 23, 2019
@arilivigni arilivigni deleted the fix_repo_ref branch November 8, 2019 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joejstuart joejstuart Awaiting requested review from joejstuart

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skatlapa @joejstuart