Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hashable edges #87

Merged
merged 2 commits into from
Oct 23, 2023
Merged

Hashable edges #87

merged 2 commits into from
Oct 23, 2023

Conversation

janosh
Copy link
Collaborator

@janosh janosh commented Oct 23, 2023

d0aa03b make DirectedEdge and UndirectedEdge inherit from new Edge abstract base class, make them hashable, handle missing info['image'] gracefully in DirectedEdge.__eq__
cffaa6b check (Un)directedEdge is hashable in test_(un)directed_edge

janosh added 2 commits October 23, 2023 09:35
@janosh
make DirectedEdge and UndirectedEdge inherit from new Edge abstract b…
d0aa03b 
…ase class, make them hashable, handle missing info['image'] gracefully in DirectedEdge.__eq__
@janosh
check (Un)directedEdge is hashable in test_(un)directed_edge
cffaa6b
@janosh janosh added enhancement New feature or request testing Test all the things labels Oct 23, 2023
@janosh janosh enabled auto-merge (squash) October 23, 2023 16:37
@janosh janosh temporarily deployed to github-pages October 23, 2023 16:41 — with GitHub Actions Inactive
@janosh janosh merged commit 8308faa into main Oct 23, 2023
6 checks passed
@janosh janosh deleted the hashable-edges branch October 23, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request testing Test all the things
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@janosh