Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add studio information #48

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from

Conversation

SamuelBMartins
Copy link

@SamuelBMartins SamuelBMartins commented Jul 21, 2022

Hi,

I noticed that the api v3 of ShokoServer contains information about the studio. They consider "Studio" what is marked as "Animation Work" on AniDB.

I modified the code so that this information can be added on Plex. Unfortunately Plex only supports one single studio, therefore I took the first one if multiple are available.

Sometimes "Animation Work" is not present on AniDB but the option "Work" is (example). In those cases I considered that information as the studio.

Let me know if I need to change something.

@Cazzar
Copy link
Owner

Cazzar commented Jul 21, 2022

This needs to target the devel branch
On top of this; consistency on the indent is required.

@SamuelBMartins SamuelBMartins changed the base branch from master to devel July 21, 2022 10:00
@SamuelBMartins
Copy link
Author

This needs to target the devel branch On top of this; consistency on the indent is required.

mb I used a new editor and I didn't notice the indentation problem

@Cazzar
Copy link
Owner

Cazzar commented Sep 20, 2022

Leaving this as-is for now, possibly marking it blocked by #43 due to it using APIv3 and there have been discussions in Shoko about some possible refactors to how the data is returned as a whole

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants