Bugfix: consider setting to open files in new tabs

History.md

@@ -19,6 +19,7 @@
 - Administrators of an installation can modify the behavior of the CAPTCHAs on registration (see README).
 - Some compatibility issues with PHP 8.4 were resolved.
 - Bugfix: Tabular data was not encoded correctly in the PHP-based PDF export.
+- Bugfix: The setting to open (PDF-)files in new browser tabs was not considered at several places.
 - Bugfix: The PDF with all amendments embedded into the motion text could not be generated if a Weasyprint-based PDF layout was selected.
 - Bugfix: If a motion with a proposed modified version was copied, merging that proposed version was not possible anymore.
 - Bugfix: It was possible for users to submit amendments for withdrawn motions.

views/pages/_content_files.php

@@ -16,8 +16,8 @@
         echo '<ul class="fileList">';
         foreach ($files as $file) {
             echo '<li data-id="' . Html::encode($file->id) . '">';
-            $title = '<span class="glyphicon glyphicon-download-alt"></span> <span class="title">' . Html::encode($file->title) . '</span>';
-            echo Html::a($title, $file->getUrl());
+            $title = '<span class="glyphicon glyphicon-download-alt" aria-hidden="true"></span> <span class="title">' . Html::encode($file->title) . '</span>';
+            echo \app\components\HTMLTools::createExternalLink($title, $file->getUrl());
             if ($contentAdmin) {
                 echo '<button type="button" class="btn btn-link deleteFile">';
                 echo '<span class="glyphicon glyphicon-trash" aria-hidden="true"></span>';