WIP - Refactor ConfigXml #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make ConfigXml#saveChanges public
sync conditions when syncthing is not running via ConfigXml
…android into 20181201-refactorConfigXml
This was referenced Dec 16, 2018
to ConfigXml
AsyncTask no longer needed
|
Reminder: We need to check the config for |
Refactor ConfigXml public functions to allow checking if a valid config exists and trigger key and config (re)genration if something is corrupted.
ToDo: Implement ConfigRouter here.
regardless if syncthing core is running or not. Remove SyncthingService dependency from SyncConditionsActivity
when syncthing core is not running
Support preserving the "introducedBy" model field of Folder.java (fixes #146)
because it is no longer required.
and accept the same address syntax as syncthing core web UI does.
- Add ConfigXml#isDeviceIdValid - Do not allow adding empty folder labels or empty device names. - Update model Folder.java so ConfigXml can handle the ignorePerms XML attribute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Refactor ConfigXml to make future enhancemens that were long "on hold" possible.
Related issues
#101 "Use default folder path given in config.xml"
#108 "IllegalStateException: Fragment already added"
#110 "Enhancement request for per-folder(device) sync conditions"
#141 "NPE crash after key and config regeneration"
#143 "Adjust the folder icon to show if it's send/receive or both"
#144 "CPU percentage is not shown on the status tab"
#145 "Always make individual sync conditions UI available"
#146 "IntroducedBy deviceID lost on config change through wrapper UI"
#147 "Wrapper doesn't use the same syntax as syncthing core's web UI for device addresses"
#148 "Syncthing wrapper "emergency" shutdown on native binary crash doesn't work"
Testing
Completed.