Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the dagger group with 2 updates #1199

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 10, 2024

Bumps the dagger group with 2 updates: com.google.dagger:dagger-compiler and com.google.dagger:dagger.

Updates com.google.dagger:dagger-compiler from 2.38.1 to 2.53.1

Release notes

Sourced from com.google.dagger:dagger-compiler's releases.

Dagger 2.53.1

Bug fixes

  • Fixes #4525: Update kotlin-jvm-metadata to 2.0.21 to remove dependency on Beta version. (84d3aa5f1)
  • Fixes #4526: Add the originating element in LazyMapKeyProxyGenerator. (5fd8ec1a3)

Dagger 2.53

Potentially breaking changes:

@Binds methods now requires explicit nullability

New: @Binds methods must explicitly declare nullability (previously we tried to infer it from the parameter). This change aligns the nullability behavior of @Binds with how nullability is treated elsewhere in Dagger by requiring it to be explict at the request and declaration sites. (4941926c5)

Suggested fix: If you get a failure due to this change, add the proper nullability to your @Binds method/parameter. For example:

@Module
interface MyModule {
-    @Binds fun bindToNullableImpl(impl: FooImpl): Foo
+    @Binds fun bindToNullableImpl(impl: FooImpl?): Foo?
}

Scopes are now banned on @Binds that delegate to production implementations.

New: Scoping an @Binds method that delegates to an @Produces implementation is not allowed. The scope was ignored anyway because production bindings are implicitly scoped. (03b237ff2)

Suggested fix: Remove the scope annotation (since the scope was ignored, this should not be a functional change).

@Module
interface MyModule {
-    @ProductionScoped
     @Binds fun bindToProductionImpl(impl: FooImpl): Foo
}

@JvmSuppressWildcards now required on multibound map requests in KSP.

New: When requesting a multibound map, users must include @JvmSuppressWildcards on the map's value, e.g. Map<K, @JvmSuppressWildcards V>. Note that this has always been the behavior in KAPT, but due to a bug in the KSP implementation we accidentally matched the request without @JvmSuppressWildcards.

Suggested fix: Unfortunately, this means users may need to add back @JvmSuppressWildcards

... (truncated)

Commits
  • d33c3e7 2.53.1 release
  • dde28e5 Make Hilt copy type-use nullness annotations, too.
  • 84d3aa5 Update kotlin (and related dependencies) to 2.0.21.
  • 09a4246 Nit
  • 5fd8ec1 Add the originating element in LazyMapKeyProxyGenerator.
  • 384ad08 Update Dagger yml and README with new latest version number.
  • 369bbc6 [Refactor]: Move members injection optimization into its RequestRepresentation.
  • 841d765 Internal changes
  • 2d75be9 Internal changes
  • 4046f2c [Refactor]: Change FrameworkField#create() to better align with the XPoet m...
  • Additional commits viewable in compare view

Updates com.google.dagger:dagger from 2.38.1 to 2.53.1

Release notes

Sourced from com.google.dagger:dagger's releases.

Dagger 2.53.1

Bug fixes

  • Fixes #4525: Update kotlin-jvm-metadata to 2.0.21 to remove dependency on Beta version. (84d3aa5f1)
  • Fixes #4526: Add the originating element in LazyMapKeyProxyGenerator. (5fd8ec1a3)

Dagger 2.53

Potentially breaking changes:

@Binds methods now requires explicit nullability

New: @Binds methods must explicitly declare nullability (previously we tried to infer it from the parameter). This change aligns the nullability behavior of @Binds with how nullability is treated elsewhere in Dagger by requiring it to be explict at the request and declaration sites. (4941926c5)

Suggested fix: If you get a failure due to this change, add the proper nullability to your @Binds method/parameter. For example:

@Module
interface MyModule {
-    @Binds fun bindToNullableImpl(impl: FooImpl): Foo
+    @Binds fun bindToNullableImpl(impl: FooImpl?): Foo?
}

Scopes are now banned on @Binds that delegate to production implementations.

New: Scoping an @Binds method that delegates to an @Produces implementation is not allowed. The scope was ignored anyway because production bindings are implicitly scoped. (03b237ff2)

Suggested fix: Remove the scope annotation (since the scope was ignored, this should not be a functional change).

@Module
interface MyModule {
-    @ProductionScoped
     @Binds fun bindToProductionImpl(impl: FooImpl): Foo
}

@JvmSuppressWildcards now required on multibound map requests in KSP.

New: When requesting a multibound map, users must include @JvmSuppressWildcards on the map's value, e.g. Map<K, @JvmSuppressWildcards V>. Note that this has always been the behavior in KAPT, but due to a bug in the KSP implementation we accidentally matched the request without @JvmSuppressWildcards.

Suggested fix: Unfortunately, this means users may need to add back @JvmSuppressWildcards

... (truncated)

Commits
  • d33c3e7 2.53.1 release
  • dde28e5 Make Hilt copy type-use nullness annotations, too.
  • 84d3aa5 Update kotlin (and related dependencies) to 2.0.21.
  • 09a4246 Nit
  • 5fd8ec1 Add the originating element in LazyMapKeyProxyGenerator.
  • 384ad08 Update Dagger yml and README with new latest version number.
  • 369bbc6 [Refactor]: Move members injection optimization into its RequestRepresentation.
  • 841d765 Internal changes
  • 2d75be9 Internal changes
  • 4046f2c [Refactor]: Change FrameworkField#create() to better align with the XPoet m...
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Dec 10, 2024
Bumps the dagger group with 2 updates: [com.google.dagger:dagger-compiler](https://github.com/google/dagger) and [com.google.dagger:dagger](https://github.com/google/dagger).


Updates `com.google.dagger:dagger-compiler` from 2.38.1 to 2.53.1
- [Release notes](https://github.com/google/dagger/releases)
- [Changelog](https://github.com/google/dagger/blob/master/CHANGELOG.md)
- [Commits](google/dagger@dagger-2.38.1...dagger-2.53.1)

Updates `com.google.dagger:dagger` from 2.38.1 to 2.53.1
- [Release notes](https://github.com/google/dagger/releases)
- [Changelog](https://github.com/google/dagger/blob/master/CHANGELOG.md)
- [Commits](google/dagger@dagger-2.38.1...dagger-2.53.1)

---
updated-dependencies:
- dependency-name: com.google.dagger:dagger-compiler
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: dagger
- dependency-name: com.google.dagger:dagger
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: dagger
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/gradle/dagger-98a4c0a774 branch from e9b715d to 079cb6d Compare December 10, 2024 20:35
@Catfriend1 Catfriend1 merged commit 7e0bdab into main Dec 10, 2024
1 check failed
@Catfriend1 Catfriend1 deleted the dependabot/gradle/dagger-98a4c0a774 branch December 10, 2024 20:38
@Catfriend1 Catfriend1 self-assigned this Dec 10, 2024
@Catfriend1 Catfriend1 added this to the v1.28.1 milestone Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant