Wrapper doesn't use the same syntax as syncthing core's web UI for device addresses #147
Comments
Catfriend1
added a commit
that referenced
this issue
Dec 21, 2018
and accept the same address syntax as syncthing core web UI does.
|
The fix will be part of an upcoming release. |
Catfriend1
pushed a commit
that referenced
this issue
Dec 22, 2018
Changelog: - "Use default folder path given in config.xml" (#101) - "IllegalStateException: Fragment already added" (#108) - "Enhancement request for per-folder(device) sync conditions" (#110) - "NPE crash after key and config regeneration" (#141) - "Adjust the folder icon to show if it's send/receive or both" (#143) - "CPU percentage is not shown on the status tab" (#144) - "Always make individual sync conditions UI available" (#145) - "IntroducedBy deviceID lost on config change through wrapper UI" (#146) - "Wrapper doesn't use the same syntax as syncthing core's web UI for device addresses" (#147) - "Syncthing wrapper "emergency" shutdown on native binary crash doesn't work" (#148) Commits: * WIP * WIP * Get folder list and paused setting when syncthing is not running Preparation to solve #110 * Fix NPE in DeviceListFragment#DEVICES_COMPARATOR * Remove blank line * Add ConfigXml#getDevices and comparator Make ConfigXml#saveChanges public * SyncthingService evaluates per folder/device sync conditions when syncthing is not running via ConfigXml * Fix typos and add stubs * Fix build errors * DEBUG - Always run syncthing binary * Fix NPE at RunConditionMonitor pointer * Add setFolderPause, setDevicePause to ConfigXml * Improve logging * Remove test mode * Better log levels * Make ConfigXml#updateIfNeeded private * Remove SyncthingService#mStartupTask AsyncTask no longer needed * Update model/Options (fixes #101) * Fix NPE after config regeneration (fixes #140) * Refactor key and config generation Refactor ConfigXml public functions to allow checking if a valid config exists and trigger key and config (re)genration if something is corrupted. * Fix crash on export/import (fixes #142) * ApiRequest - Disable verbose log in release builds * ConfigXml#updateIfNeeded - Disable "startBrowser" because it applies to desktop environments and cannot start a mobile browser app * MainActivity - Always show all tabs * Show folder/device tab contents from config.xml if syncthing is not running * Update ConfigXml#getDevices return model - compression - introducer * Device tab - Hide in/out rate if syncthing is not running or if the device is paused * Update device item layout * MainActivity/Devices - Prevent showing outdated status after syncthing core transitioned from "active" to "disabled" * MainActivity/Folders - Prevent showing outdated status after syncthing core transitioned from "active" to "disabled" * Add ConfigRouter class Provides a transparent access to the config if ... a) Syncthing is running and REST API is available. b) Syncthing is NOT running and config.xml is accessed. * Add pref - Cache local device ID * Allow excluding self in ConfigRouter#getDevices * Allow excluding self in ConfigRouter#getDevices (2) * Update Folder model default values * Update Folder model defaults (2) - copiers - hashers * WIP - ConfigXml - FolderActivity Remove unused pref inject code Cache local device ID in pref Reduce verbose logging in release builds Extend ConfigXml#getFolders Extend ConfigXml#getDevices Fix ConfigXml#setDevicePause ToDo ConfigXml#getFolderIgnoreList needs to be implemented * Implemented ConfigXml#getFolderIgnoreList * Extend ConfigXml#getDevices - device.addresses * WIP - DeviceActivity Make it available when syncthing is not running * Fix unsuccessful API bumps while syncthing is starting * Fix space * Adjust the folder icon to show if it's send/receive or both (fixes #143) * Fix lint - item_device_list * Preserve active tab when syncthing core transitions between running and not running * Add xmlns:android to item_folder_list * Remove unused reference from item_folder_list * Add device icon to device tab * Fix CPU percentage not showing (fixes #144) * SyncthingService - Polish iterator code * Fix MainActivity#updateViewPager (fixes #108) * Add ConfigXml#updateFolder, updateDevice (1) * Add ConfigRouter#updateFolder, updateDevice * Add missing "final" to ConfigXml#updateDevice * WIP - FolderActivity - Update updateFolder via ConfigRouter ToDo: Implement ConfigRouter here. * ConfigRouter - Fix missing return * DeviceActivity - Update device via ConfigRouter * Always make individual sync conditions UI available (fixes #145) regardless if syncthing core is running or not. Remove SyncthingService dependency from SyncConditionsActivity * Fix incorrect folder type icon shown when syncthing core is not running * Add "introducedBy" to folder and device model (fixes #146) * Add Folder#getDevices to model * ConfigXml#updateFolder - Writeback devices sharing the folder Support preserving the "introducedBy" model field of Folder.java (fixes #146) * Add ConfigXml#updateFolder - Versioning * Remove SyncthingService dependency from FolderPickerActivity because it is no longer required. * Update ToDo remarks * Add ConfigXml#updateDevice - Addresses * Fix DeviceActivity#persistableAddresses to be more graceful (fixes #147) and accept the same address syntax as syncthing core web UI does. * Add ConfigXml#removeFolder, removeDevice * Add ConfigXml#addDevice, addFolder - Add ConfigXml#isDeviceIdValid - Do not allow adding empty folder labels or empty device names. - Update model Folder.java so ConfigXml can handle the ignorePerms XML attribute * Fix Syncthing wrapper "emergency" shutdown on native binary crash (fixes #148) * Update translation de * Add ConfigXml#postFolderIgnoreList * Update APK version to 0.14.54.3 / 4182 * Revert DEBUG - Always run syncthing binary * Update whatsnew
|
Already fixed, ref # syncthing/syncthing-android#2076 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reproducer
Note: The same syntax works okay in syncthing core's Web UI.
Version Information
The text was updated successfully, but these errors were encountered: