Add custom acceptable job run conclusions #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `acceptable_conclusions` as an action input parameter. It is a comma-separated list of acceptable conclusions for _all_ status checks.
Missing values in the 'acceptable_conclusions' inputs.
Ensure parsed acceptable conclusions is a list of unique, valid conclusions.
Also, use trap to do cleanup
A boolean input to determine whether or not to immediately fail if a status check fails or wait for all checks to finish before failing. Miscellaneous: - Add acceptable_conclusions to path CI job. - Remove debug from path CI job. - Remove default value for --acceptable-conclusion push-action option.
Always parse acceptable_conclusions input.
Move it into the block that gets executed if the `wait_for_checks` action was given.
This is to test `--fail-fast` testing.
To ensure fail_fast actually works as intended, one needs to manually check the output in the CI job to see if it truly works and doesn't ignore the option. In order to automate this, the best way I see is to store everything reported to stderr as an action output - but that seems like overkill just to be able to do testing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #149
Add
acceptable_conclusionsas an action input parameter.It is a comma-separated list of acceptable conclusions for all status checks.
Update the CI jobs to test the parameter.
Should also close #153