Wait to load PgSearch::Document until after ActiveRecord has loaded

[lleger]

Loading the PgSearch::Document model without waiting for ActiveRecord to
load can cause problems because it causes ActiveRecord to pull
configuration into ActiveRecord::Base before the initializers get
loaded. This means ActiveRecord::Base could accidentally have inaccurate
configuration.

The fix for this is to wait until ActiveRecord has fully loaded before
requiring the model.

ref: rails/rails#23589

[lleger]

I ran into this issue today. After including the pg_search gem, my specs began to fail. AR changed a config in Rails 5 to add a validation to all belongs_to by default, but that flag is turned on in an initializer. Requiring the PgSearch::Document model before ActiveRecord loaded meant that this config was set to nil, which isn't the right behavior, and caused my specs to fail.

This has happened in a number of gems after the Rails 5 release. Some more reference:

• Rails 5.0.0beta2: Weird behaviour of config belongs_to_required_by_default rails/rails#23589
• heartcombo/devise@c2c74b0
• Rails 5 belongs_to association behavior overridden collectiveidea/delayed_job_active_record#128

[jkhas8]

👍 I have the same problem

[lleger]

Thanks for merging this @nertzy! Any chance we can get a new release soon so we can switch from our branched version?

[lleger]

@nertzy Any plans to release a new version with this and the latest changes from master? Would like to get the official release back into production.

[nertzy]

This fix is in v2.1.0 and later.