Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spatial index widgets #34

Open
wants to merge 35 commits into
base: main
Choose a base branch
from

Conversation

@juandjara juandjara requested a review from donmccurdy December 2, 2024 15:50
Copy link
Member

@donmccurdy donmccurdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is nicely structured! A few comments/questions, still working my way though the code review. :)

src/sources/h3-query-source.ts Outdated Show resolved Hide resolved
src/sources/h3-query-source.ts Show resolved Hide resolved
src/spatial-index.ts Outdated Show resolved Hide resolved
src/widget-sources/widget-base-source.ts Outdated Show resolved Hide resolved
src/spatial-index.ts Show resolved Hide resolved
examples/components/widgets/category-widget.ts Outdated Show resolved Hide resolved
src/models/model.ts Outdated Show resolved Hide resolved
src/widget-sources/widget-base-source.ts Show resolved Hide resolved
src/spatial-index.ts Outdated Show resolved Hide resolved
src/spatial-index.ts Outdated Show resolved Hide resolved
src/spatial-index.ts Show resolved Hide resolved
@donmccurdy
Copy link
Member

@juandjara great work here! I think all that's left after #41 is the one other comment above, removing the spatialFiltersResolution from the function options and always computing it internally when a spatial filter is used.

As the next step, should we publish this as an alpha release so that external examples can be built on it? If you're ready, feel free to do that any time. The steps would:

  1. Update package.json#version to 0.4.1-alpha.0
  2. Run yarn postversion
  3. Manually run the release action, selecting this branch as the target, as described in CONTRIBUTING.md

src/models/model.ts Outdated Show resolved Hide resolved
Co-authored-by: Don McCurdy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants