Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix animation filter category selected #661

Closed
wants to merge 55 commits into from
Closed

Fix animation filter category selected #661

wants to merge 55 commits into from

Conversation

elenatorro
Copy link
Contributor

Fix CartoDB/cartoframes#1359 and CartoDB/cartoframes#1412

This PR:

  • Restarts the animation when a filter is applied
  • Fixes a dependent issue due to a broken d3 dependency (more info here)
  • Fixes a typescript error when importing the mitt event library

elenatorro and others added 30 commits June 28, 2019 14:30
@elenatorro
Connect the VL Bridge with the Animation Controls widget
00551ec
@elenatorro
Add specs
ab92a27
@elenatorro
Fix lint
4181197
@elenatorro
Add specs, snapshots and e2e tests
590e38b
@elenatorro @rjimenezda
Update packages/components/src/components/as-animation-controls-widge…
7cc5675 
…t/as-animation-controls-widget.scss

Co-Authored-By: Román Jiménez <[email protected]>
@elenatorro @rjimenezda
Update packages/components/src/components/as-animation-controls-widge…
1af992f 
…t/as-animation-controls-widget.scss

Co-Authored-By: Román Jiménez <[email protected]>
@elenatorro @rjimenezda
Update packages/components/src/components/as-range-slider/slider/as-r…
68d257c 
…ange-slider.tsx

Co-Authored-By: Román Jiménez <[email protected]>
@elenatorro @rjimenezda
Update examples/bridge/animation-controls/simple.html
13b3e02 
Co-Authored-By: Román Jiménez <[email protected]>
@elenatorro @rjimenezda
Update packages/components/src/components/as-range-slider/slider/as-r…
7a83f10 
…ange-slider.spec.ts

Co-Authored-By: Román Jiménez <[email protected]>
@elenatorro
Fix range slider properties
8483e4c
@elenatorro
Fix variable usage
31a7af7
@elenatorro
Modify the usage of variableName
859111c
@elenatorro
Fix example
ba623ff
@elenatorro
Allow property and variable
ca869a6
@elenatorro
Use variable when filtering
8f6d75f
@elenatorro
Center range slider
f9b6819
@elenatorro
Allow other properties for animation
7c2b451
@elenatorro
Allow all binary expressions in both TimeSeries and AnimationControls
ada75d5
@elenatorro
Add documentation
a3ae87e
@elenatorro
Merge pull request #634 from CartoDB/feature/812-cartoframes-add-anim…
71f587b 
…ation-widget

Add Animation Controls widget
@elenatorro
Use variable from viz style and simplify API
7ea739b
@elenatorro
Add progress value
87002a9
@elenatorro
Format and style progress value
4de65c1
@elenatorro
Add check for TimeZoneDate format in CARTO VL
696fd85
@elenatorro
Fix specs
a70a3f2
@elenatorro
Add documentation
c103d6d
@elenatorro
Add animation controls widget examples
7249b67
@elenatorro
Add bridge docs
2614eee
@elenatorro
Fix examples and review changes
058ec42
@elenatorro
Fix TimeSeries
f8b4dda
@elenatorro
Revert variableName usage
8b2276d
@elenatorro
Allow style properties
97dd093
@elenatorro
Add combined filters example
5633222
@elenatorro
Hide header if no heading or description are present
6f45436
@elenatorro
Merge pull request #635 from CartoDB/feature/812-cartoframes-change-a…
ace18b4 
…nimation-controls-api

Change animation controls API
@elenatorro
Merge branch 'develop' of github.com:CartoDB/airship into develop
a2af034
@elenatorro
Merge branch 'develop' of github.com:CartoDB/airship into develop
c301c67
@elenatorro
Merge branch 'develop' of github.com:CartoDB/airship into develop
57863cb
@elenatorro
Merge branch 'develop' of github.com:CartoDB/airship into develop
ff0007a
@elenatorro
Merge branch 'develop' of github.com:CartoDB/airship into develop
f389293
@elenatorro
Merge branch 'develop' of github.com:CartoDB/airship into develop
5deba87
@elenatorro
Reset animation when filter changes
3358a2c
@elenatorro
Restart the animation everytime the filter changes
fd7e00d
@elenatorro
Fix lint
50892ca
Jesus89
Jesus89 approved these changes Jan 9, 2020
View reviewed changes
Copy link
Member

@Jesus89 Jesus89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but maybe an Airship expert should take a look :) cc @jesusbotella

@elenatorro
Copy link
Contributor Author

ok 👍 There's a lint issue I still have to solve but it's an easy one

jesusbotella
jesusbotella suggested changes Jan 9, 2020
View reviewed changes
Copy link
Contributor

@jesusbotella jesusbotella left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, but let's solve the import thing :)

@elenatorro elenatorro changed the base branch from develop to 2.0.x January 9, 2020 10:54
@elenatorro elenatorro changed the base branch from 2.0.x to develop January 9, 2020 10:54
@elenatorro
Copy link
Contributor Author

Note: this PR is a bit dirty and I've opened a new one in order to follow conventional commits and the Airship guidelines: #662

@elenatorro elenatorro closed this Jan 9, 2020
@elenatorro elenatorro deleted the fix-animation-filter-category-selected branch January 9, 2020 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jesusbotella jesusbotella jesusbotella requested changes

@Jesus89 Jesus89 Jesus89 approved these changes

Assignees

@Jesus89 Jesus89

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Animation is not properly updated after a category is selected
3 participants
@elenatorro @Jesus89 @jesusbotella