Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop-rspec and rubocop-rspec_rails #45

Merged
merged 5 commits into from
Jun 25, 2024
Merged

Conversation

jgarber623
Copy link

@jgarber623 jgarber623 commented Jun 25, 2024

Description

This PR combines the updates to rubocop-rspec and rubocop-rspec_rails as they wouldn't pass in the individual Dependabot PRs linked below. Also, the RuboCop constraint is updated to ~> 1.61 to align with these gems and rubocop-factory_bot.

As a result of these changes, the gem version is bumped to v2.0.0.

Commits

  • Bump minimum RuboCop version to 1.61
  • Bump rubocop-rspec and rubocop-rspec_rails

A few of our dependencies here have upped their supported RuboCop versions to v1.61:

- rubocop-factory_bot
- rubocop-rspec
- rubocop-rspec_rails

This commit does the same for this gem.
Closes #42 and #43 which wouldn't pass independent of one another.
@jgarber623 jgarber623 requested a review from a team as a code owner June 25, 2024 14:46
@jgarber623 jgarber623 self-assigned this Jun 25, 2024
The change to this gem's rubocop constraint (`~> 1.61`) was in v2.26.1.

🤦🏻‍♂️
@jgarber623 jgarber623 merged commit 583c2af into main Jun 25, 2024
8 checks passed
@jgarber623 jgarber623 deleted the rubocop-rspec-updates branch June 25, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants