command process to install globally exx
#1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| PATH_INSTALL=$HOME/.sub | ||
|
|
||
| installation(){ | ||
| CURRENT_PATH=`pwd` |
There was a problem hiding this comment.
Test if CURRENT_PATH is not equivalent to PATH_INSTALL
|
|
||
| PATH_INSTALL=$HOME/.sub | ||
|
|
||
| installation(){ |
There was a problem hiding this comment.
Could you rename the function "copy" ?
| echo "Create symlinks into $BINARY_PATH" | ||
| ln -s $SOURCE_PATH/exx/libexec/exx $BINARY_PATH | ||
| echo "Done !" | ||
| echo "Check vertification installation by running ``exx info`` for example" |
There was a problem hiding this comment.
Why "vertification installation" ?
| fi | ||
|
|
||
| # if path is the current directory, don't copy | ||
| if [ "$path" == "." ]; then |
There was a problem hiding this comment.
Remove COPY_DIR variable
Move the symlink and exit function calls up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.