Make clib more consistent
#1770
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ischoegl
force-pushed
the
update-clib-types
branch
from
5017f36 to
f4dfe02
Compare
ischoegl
force-pushed
the
update-clib-types
branch
7 times, most recently
from
4c8d520 to
92e9a28
Compare
ischoegl
force-pushed
the
update-clib-types
branch
14 times, most recently
from
3da80fa to
cad4dc8
Compare
Replaced by SharedCabinet::at
Replaced by SharedCabinet::as
ischoegl
force-pushed
the
update-clib-types
branch
2 times, most recently
from
1284698 to
88c91a1
Compare
ischoegl
force-pushed
the
update-clib-types
branch
2 times, most recently
from
ab7b8ba to
b4b41a9
Compare
Warnings are raised when inconsistent interfaces are detected. Fix some crosswalks, and add newInterface and Func1 to the scaffolds.
ischoegl
force-pushed
the
update-clib-types
branch
from
b4b41a9 to
66f6173
Compare
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧
size_tfrom CLib APIconst double*consistently for all settersSharedCabinet::itemandSharedCabinet::getthermo_equilibrateCurrently missing: ensure safe casting of
size_ttoint, ...🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧
If applicable, fill in the issue number this pull request is fixing
Closes #1450
Partially addresses Cantera/enhancements#199 (.NET side)
If applicable, provide an example illustrating new features this pull request is introducing
Checklist
scons build&scons test) and unit tests address code coverage