Ambiguous references in clib's Cabinet<M>::index

[ischoegl]

Problem description

When calling a destructor for a Solution object via soln_del using the clib API, associated ThermoPhase, Kinetics and Transport objects are deallocated. As integer entry numbers ('handles') are not available, the destructor relies on Cabinet<M>::index, which returns the last entry of a reverse lookup table. There is no guarantee that the correct entry is removed, leading to potentially unpredictable behavior and memory leaks.

System information

• Cantera version: 3.1a3
• OS: any
• Python/MATLAB/other software versions: N/A

Additional context

• found in context of Remove clib *newFromFile from MATLAB / fix memory leaks #1754