Remove clib *newFromFile from MATLAB / fix memory leaks

[ischoegl]

Changes proposed in this pull request

• Remove clib's *_newFromFile constructors from MATLAB; use pathways using Solution exclusively instead
• Fix memory leak in clib where automatically added adjacent phases could not be removed
• Make MATLAB Interface.adjacent consistent with Python version (select phase by name rather than index)
• Fix ambiguous references that will lead to memory leaks (going back to Smart clib cabinets / add Solution to clib API #1448)

If applicable, fill in the issue number this pull request is fixing

Resolves #1756
Partially addresses Cantera/enhancements#199

Example

New in experimental MATLAB:

surf = Interface('ptcombust.yaml', 'Pt_surf');
gas = surf.adjacent('gas');

Checklist

• The pull request includes a clear description of this code change
• Commit messages have short titles and reference relevant issues
• Build passes (scons build & scons test) and unit tests address code coverage
• Style & formatting of contributed code follows contributing guidelines
• The pull request is ready for review

[codecov]

Codecov Report

Attention: Patch coverage is 72.72727% with 18 lines in your changes missing coverage. Please review.

Project coverage is 73.11%. Comparing base (bb3f51d) to head (66f8ef5).

Files	Patch %	Lines
src/clib/ct.cpp	75.00%	10 Missing and 2 partials ⚠️
src/clib/Cabinet.h	66.66%	3 Missing and 3 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1754      +/-   ##
==========================================
- Coverage   73.12%   73.11%   -0.01%     
==========================================
  Files         381      381              
  Lines       54134    54175      +41     
  Branches     9224     9226       +2     
==========================================
+ Hits        39587    39612      +25     
- Misses      11589    11602      +13     
- Partials     2958     2961       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ischoegl]

Added a fix for #1756: while the issue was pre-existing, this PR surfaced some symptoms, where incorrect Cabinet entries were deleted when Solution destructors were called. The PR is (again) ready for review.

PS: force-push was only to fix typos in commit messages / prevent CI failures.

[speth]

Thanks, @ischoegl. This looks mostly good to me. Just had a couple of small suggestions.

[ischoegl]

Thanks, @ischoegl. This looks mostly good to me. Just had a couple of small suggestions.

Thanks for the prompt review! I think it's all taken care of.