Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(style): ESRI Dynamic handles multiple styles with same label #2666

Conversation

DamonU2
Copy link
Member

@DamonU2 DamonU2 commented Dec 17, 2024

Closes #2597

Description

Fixes issues with ESRI Dynamic layer styles. Default is now respected for class break styles, multiple entries for the same style are properly combined, and default values are better handled in class breaks.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

https://damonu2.github.io/geoview/demos-navigator.html?config=./configs/navigator/16-esri-dynamic.json
https://damonu2.github.io/geoview/add-layers.html

3af377be-801d-4ebf-9137-869b3080bfa5
88c1689b-9327-406e-860b-3d0e2dd518fa
3fffdd62-41e7-443c-b607-8d5825e12600
f38ca22a-2a3f-4e8a-86b5-e74f599e5cb6
000183ed-8864-42f0-ae43-c4313a860720 (Metal mines (ID: 4))

Checklist:

  • I have build (rush build) and deploy (rush host) my PR
  • I have connected the issues(s) to this PR
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have created new issue(s) related to the outcome of this PR is needed
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

This change is Reviewable

@DamonU2 DamonU2 requested a review from jolevesq December 17, 2024 16:10
@DamonU2 DamonU2 self-assigned this Dec 17, 2024
@jolevesq jolevesq requested a review from Alex-NRCan December 17, 2024 16:14
Copy link
Member

@Alex-NRCan Alex-NRCan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jolevesq)

@DamonU2 DamonU2 force-pushed the 2597-visibility-toggle-errors branch from 542919e to 95846ef Compare December 18, 2024 23:31
@DamonU2 DamonU2 force-pushed the 2597-visibility-toggle-errors branch from 95846ef to 46057e0 Compare December 19, 2024 16:03
Copy link
Member

@jolevesq jolevesq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @DamonU2)

@jolevesq jolevesq merged commit 5b51ec7 into Canadian-Geospatial-Platform:develop Dec 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants