fix(style): ESRI Dynamic handles multiple styles with same label #2666
+312
−308
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2597
Description
Fixes issues with ESRI Dynamic layer styles. Default is now respected for class break styles, multiple entries for the same style are properly combined, and default values are better handled in class breaks.
Fixes # (issue)
Type of change
How Has This Been Tested?
https://damonu2.github.io/geoview/demos-navigator.html?config=./configs/navigator/16-esri-dynamic.json
https://damonu2.github.io/geoview/add-layers.html
3af377be-801d-4ebf-9137-869b3080bfa5
88c1689b-9327-406e-860b-3d0e2dd518fa
3fffdd62-41e7-443c-b607-8d5825e12600
f38ca22a-2a3f-4e8a-86b5-e74f599e5cb6
000183ed-8864-42f0-ae43-c4313a860720 (Metal mines (ID: 4))
Checklist:
I have made corresponding changes to the documentationI have added tests that prove my fix is effective or that my feature worksNew and existing unit tests pass locally with my changesThis change is