Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(details): Display detail fields when service returns alias instea… #2658

Conversation

DamonU2
Copy link
Member

@DamonU2 DamonU2 commented Dec 12, 2024

…d of field name

Fixes some of #2596, info is displayed properly, but icons are not fixed.

Description

Fixes issue with some layers returning the field alias instead of the field name when fetching feature properties. Icons remain broken.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

https://damonu2.github.io/geoview/add-layers.html

4baa66ad-aa29-4233-a6a8-7f5cbefb5ea8
8ad80782-d468-44dc-af4f-ddf8ed44ce0a
dbe22a3d-0f34-40f5-a40b-83e68f9c3c37
4efad8d5-b7c7-4ea8-b95c-f41f76f24e63
a88f1437-f93f-42e8-9b44-6cdc2213a172
9edee77a-4cb9-4e64-bb37-c5e66a82108d
0b88062f-ebbe-46c6-ab19-54fd226e9aa7

Checklist:

  • I have build (rush build) and deploy (rush host) my PR
  • I have connected the issues(s) to this PR
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have created new issue(s) related to the outcome of this PR is needed
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

This change is Reviewable

Sorry, something went wrong.

@DamonU2 DamonU2 requested a review from jolevesq December 12, 2024 17:35
@DamonU2 DamonU2 self-assigned this Dec 12, 2024
Copy link
Member

@jolevesq jolevesq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @DamonU2)


packages/geoview-core/src/geo/layer/gv-layers/abstract-gv-layer.ts line 587 at r1 (raw file):

                fieldKey: fieldKeyCounter++,
                value:
                  this.getFieldValue(feature, fieldName, fieldEntry!.type as 'string' | 'number' | 'date') ||

CAn you add a comment why we this ||

…d of field name

Fixes some of Canadian-Geospatial-Platform#2596, info is displayed properly, but icons are not fixed.
@DamonU2 DamonU2 force-pushed the 2596-missing-details-info branch from e84c5aa to ca105b9 Compare December 13, 2024 15:32
Copy link
Member Author

@DamonU2 DamonU2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @jolevesq)


packages/geoview-core/src/geo/layer/gv-layers/abstract-gv-layer.ts line 587 at r1 (raw file):

Previously, jolevesq (Johann Levesque) wrote…

CAn you add a comment why we this ||

Done.

Copy link
Member

@jolevesq jolevesq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @DamonU2)

Copy link
Member

@jolevesq jolevesq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @DamonU2)

@jolevesq jolevesq merged commit 0041cbf into Canadian-Geospatial-Platform:develop Dec 13, 2024
6 checks passed
@DamonU2 DamonU2 deleted the 2596-missing-details-info branch December 13, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants