fix(feature info): repairs feature info for geocore layers

[DamonU2]

Closes #2593
Closes #2210
Closes #563

Description

Fixes some issues with getting the feature info for some geocore layers. Adds support for html response from WMS getFeatureInfo.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

https://damonu2.github.io/geoview/add-layers.html
HTML WMS: 6433173f-bca8-44e6-be8e-3e8a19d3c299

Checklist:

• I have build (rush build) and deploy (rush host) my PR
• I have connected the issues(s) to this PR
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• My changes generate no new warnings
• I have created new issue(s) related to the outcome of this PR is needed
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

---

This change is 

[jolevesq]

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @DamonU2)

---

packages/geoview-core/src/geo/layer/gv-layers/abstract-gv-layer.ts line 255 at r1 (raw file):

      // If queryable
      if (layerConfig.source?.featureInfo?.queryable === false) {

Why the previous was not working?

[Alex-NRCan]

Reviewed 6 of 7 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @DamonU2 and @jolevesq)

---

packages/geoview-core/src/geo/layer/gv-layers/abstract-gv-layer.ts line 255 at r1 (raw file):

Previously, jolevesq (Johann Levesque) wrote…

Why the previous was not working?

It essentially turns the condition to false when source?.queryable is undefined instead of true by default when it's undefined.
Btw, should probably edit the comment just above the if.

[DamonU2]

Only WMS layer I know of with HTML return on feature info: 6433173f-bca8-44e6-be8e-3e8a19d3c299

[jolevesq]

Reviewable status: 5 of 7 files reviewed, 1 unresolved discussion (waiting on @Alex-NRCan and @DamonU2)

---

packages/geoview-core/src/geo/layer/gv-layers/abstract-gv-layer.ts line 255 at r1 (raw file):

Previously, Alex-NRCan (Alex) wrote…

It essentially turns the condition to false when source?.queryable is undefined instead of true by default when it's undefined.
Btw, should probably edit the comment just above the if.

We shuold have the warning even when undefined.... should we revert

[jolevesq]

Reviewable status: 5 of 7 files reviewed, 1 unresolved discussion (waiting on @Alex-NRCan and @DamonU2)

---

packages/geoview-core/src/geo/layer/gv-layers/abstract-gv-layer.ts line 255 at r1 (raw file):

Previously, jolevesq (Johann Levesque) wrote…

We shuold have the warning even when undefined.... should we revert

If we need to continue when undefined, we need a GV comment to explain why we should do this

[DamonU2]

Reviewable status: 3 of 7 files reviewed, 1 unresolved discussion (waiting on @Alex-NRCan and @jolevesq)

---

packages/geoview-core/src/geo/layer/gv-layers/abstract-gv-layer.ts line 255 at r1 (raw file):

Previously, Alex-NRCan (Alex) wrote…

It essentially turns the condition to false when source?.queryable is undefined instead of true by default when it's undefined.
Btw, should probably edit the comment just above the if.

Done.

[jolevesq]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: 4 of 7 files reviewed, 1 unresolved discussion (waiting on @Alex-NRCan)

---

packages/geoview-core/src/geo/layer/gv-layers/abstract-gv-layer.ts line 255 at r1 (raw file):

Previously, DamonU2 (Damon Ulmi) wrote…

Done.

GV need to be capitalize letter.... Do we want logger.error? Just looger.warning should be enough?

[jolevesq]

Reviewed 1 of 3 files at r4.
Reviewable status: 5 of 7 files reviewed, 1 unresolved discussion (waiting on @Alex-NRCan)

[DamonU2]

Reviewable status: 5 of 7 files reviewed, 1 unresolved discussion (waiting on @Alex-NRCan and @jolevesq)

---

packages/geoview-core/src/geo/layer/gv-layers/abstract-gv-layer.ts line 255 at r1 (raw file):

Previously, jolevesq (Johann Levesque) wrote…

GV need to be capitalize letter.... Do we want logger.error? Just looger.warning should be enough?

Done. Small gv actually works the same.

[jolevesq]

Reviewed 1 of 3 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @DamonU2)

[jolevesq]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @DamonU2)