Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean(demo): Remove obsolete demos pages #2619

Merged

Conversation

jolevesq
Copy link
Member

@jolevesq jolevesq commented Nov 27, 2024

Closes #2618

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #2618

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Hosted November 17th 9am

https://jolevesq.github.io/geoview/

  • no more type of layers demo. Everything is in the demo navigator

Checklist:

  • I have build (rush build) and deploy (rush host) my PR
  • I have connected the issues(s) to this PR
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have created new issue(s) related to the outcome of this PR is needed
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

This change is Reviewable

@jolevesq jolevesq requested a review from DamonU2 November 27, 2024 13:58
Copy link
Member Author

@jolevesq jolevesq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 49 of 49 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @DamonU2)

@jolevesq jolevesq force-pushed the 2618-cleanup-layers branch from bf8e833 to 169abb8 Compare November 27, 2024 14:23
Copy link
Member Author

@jolevesq jolevesq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 5 files at r2, 3 of 3 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @DamonU2)

@jolevesq jolevesq merged commit 922790b into Canadian-Geospatial-Platform:develop Nov 27, 2024
6 checks passed
Copy link
Member

@DamonU2 DamonU2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 44 of 49 files at r1, 2 of 5 files at r2, 3 of 3 files at r3, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions


packages/geoview-core/public/templates/demos-navigator.html line 152 at r3 (raw file):

          <option value="./configs/navigator/28-geocore.json">Layer GeoView - GeoCore -</option>
          <option value="./configs/navigator/27-geocore-custom.json">Layer GeoView - GeoCore Custom Config -</option>
          <option value="./configs/navigator/29-geopackages.json">Layer GeoView - GeoPackages -</option>

Why add "GeoView" to just these?


packages/geoview-core/public/templates/pygeoapi-processes.html line 121 at r3 (raw file):

  <script src="codedoc.js"></script>
  <script>
    // // initialize cgpv and api events, a callback is optional, used if calling api's after the rendering is ready

"//" doubled up


packages/geoview-core/public/configs/navigator/16-esri-dynamic.json line 15 at r3 (raw file):

      {
        "geoviewLayerId": "472ef86d-7f7c-423b-a7d2-b6f92b79fd6d",
        "geoviewLayerType": "geoCore"

Not related to your PR, but we should move this layer to the bottom as it covers all the other layers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CLEAN] Remove the type of layers template
2 participants