fix(table): EsriDynamic does not have right icon after no fetch of ge…

[jolevesq]

…ometry

Closes #2585-table-icon-dynamic

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Since we do not fetch geometry for esriDynamic, the geoview-renderer defaulted to first icon for all feature.
Fixes #2585, #2536

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Hosted November 10th: 11:20
https://jolevesq.github.io/geoview/demos-navigator.html?config=./configs/navigator/16-esri-dynamic.json

• See table with all icons for esri dynamic (2585)
• Toggle visibility class for layers and open table to see values are filtered (2536)

https://jolevesq.github.io/geoview/demos-navigator.html?config=./configs/navigator/17-esri-feature.json

• Toggle visibility class for layers and open table to see values are filtered (2536)

https://jolevesq.github.io/geoview/demos-navigator.html?config=./configs/navigator/19-geojson.json

• Toggle visibility class for layers and open table to see values are filtered (2536)
• See table polygon missing Alberta pink icon. It is there now (2536)

Checklist:

• I have build (rush build) and deploy (rush host) my PR
• I have connected the issues(s) to this PR
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• My changes generate no new warnings
• I have created new issue(s) related to the outcome of this PR is needed
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

---

This change is 

[Alex-NRCan]

Reviewed 8 of 12 files at r2, 2 of 4 files at r3, 3 of 3 files at r4, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @DamonU2 and @jolevesq)

---

packages/geoview-core/src/geo/layer/gv-layers/raster/gv-esri-dynamic.ts line 128 at r4 (raw file):

      // Guess the geometry type by taking the first style key
      // TODO: Refactor - Layers migration. Johann: This will be modified with new schema, there is no more geometry on style
      const [geometryType] = layerConfig.getTypeGeometries();

Nice cleanup

---

packages/geoview-core/src/geo/utils/renderer/geoview-renderer.ts line 1603 at r4 (raw file):

  let canvas: HTMLCanvasElement | undefined;

  // GV: Some time, the feature will have no geometry e.g. esriDynamic has we fetch geometry only when needed

Minor typos:
Some time => Sometimes
has we => as we

---

packages/geoview-core/src/geo/utils/renderer/geoview-renderer.ts line 1600 at r4 (raw file):

  legendFilterIsOff?: boolean,
  useRecycling?: boolean,
  callbackForDataUrl?: () => Promise<string | null>

Si tu as le temps de m'en parler un peu, je serais curieux de voir comment tu as remplacé ce callback. Il me semble que ça servait? Ça ne ramasse plus le legendIcons![0].iconImage dans abstract-geoview-layers.formatFeatureInfoResult() et abstract-gv-layers?

[DamonU2]

Reviewed 8 of 12 files at r2, 2 of 4 files at r3, 3 of 3 files at r4, 2 of 2 files at r5, all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @jolevesq)

---

packages/geoview-core/src/api/event-processors/event-processor-children/legend-event-processor.ts line 696 at r5 (raw file):

    // Sort class breaks by minValue for binary search
    // GV: Vlaues can be number, date, string, null or undefined. Should it be only Date or Number

Vlaues > Values

---

packages/geoview-core/src/api/event-processors/event-processor-children/legend-event-processor.ts line 697 at r5 (raw file):

    // Sort class breaks by minValue for binary search
    // GV: Vlaues can be number, date, string, null or undefined. Should it be only Date or Number
    // GV: undefine or null should not be allowed in class break style

undefine > undefined