fix(table): UX and filter export #2547
Conversation
There was a problem hiding this comment.
Reviewed 16 of 16 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Alex-NRCan and @DamonU2)
There was a problem hiding this comment.
Reviewed 16 of 16 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Alex-NRCan and @jolevesq)
packages/geoview-core/public/locales/en/translation.json line 202 at r1 (raw file):
"downloadAsCSV": "Download CSV", "filterMap": "Filter map", "stopFilterMap": "Stop filter map",
This seems weird - "Stop filtering map" or just "Filter Map" because it is a toggle?
There was a problem hiding this comment.
Reviewed 16 of 16 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @jolevesq)
packages/geoview-core/src/geo/layer/gv-layers/raster/gv-esri-dynamic.ts line 647 at r1 (raw file):
* @private */ static #formatFieldValue(fieldName: string, rawValue: string | number | Date, sourceFeatureInfo: TypeFeatureInfoLayerConfig): string {
I think this PR will need to be rebased once my PR will be merged, because I believe I've changed this as well in my PR.
There was a problem hiding this comment.
Reviewable status: 13 of 16 files reviewed, 1 unresolved discussion (waiting on @Alex-NRCan and @DamonU2)
packages/geoview-core/public/locales/en/translation.json line 202 at r1 (raw file):
Previously, DamonU2 (Damon Ulmi) wrote…
This seems weird - "Stop filtering map" or just "Filter Map" because it is a toggle?
I was thinking about it. I tried both. Will put it back and let me know what you think
There was a problem hiding this comment.
Reviewable status: 13 of 16 files reviewed, 1 unresolved discussion (waiting on @Alex-NRCan and @jolevesq)
packages/geoview-core/public/locales/en/translation.json line 202 at r1 (raw file):
Previously, jolevesq (Johann Levesque) wrote…
I was thinking about it. I tried both. Will put it back and let me know what you think
Looks better to me, but it's removed from the french but still listed here
There was a problem hiding this comment.
Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @jolevesq)
jolevesq
force-pushed
the
2506-table-ux
branch
from
8dc7d90 to
f233e3d
Compare
jolevesq
merged commit 0a37a0a
into
Canadian-Geospatial-Platform:develop
* fix(table): Fix table for UX Closes Canadian-Geospatial-Platform#2506 * fix filterMap and style * fix display, file name, clear filters * fix header --------- Co-authored-by: jolevesq <[email protected]>
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
This PR is fixing issues and add UX improvement (comments from the workshop about the data table)
Fixes #2506, #2414
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Hosted October 11th, noon: https://jolevesq.github.io/geoview/demos-navigator.html?config=./configs/navigator/16-esri-dynamic.json
Go to data table, filter rows then download and see results
Checklist:
I have made corresponding changes to the documentationI have added tests that prove my fix is effective or that my feature worksNew and existing unit tests pass locally with my changesThis change is