feat(event): Event added to API for map ready

[DamonU2]

Description

Added an API event to inform user when the map viewer is ready, for use outside of cgpv.init

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Tested using event to log map ID in the console
https://damonu2.github.io/geoview/

Checklist:

• I have build (rush build) and deploy (rush host) my PR
• I have connected the issues(s) to this PR
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• My changes generate no new warnings
• I have created new issue(s) related to the outcome of this PR is needed
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

---

This change is 

[jolevesq]

Reviewed 2 of 4 files at r2, all commit messages.
Reviewable status: 2 of 4 files reviewed, 1 unresolved discussion (waiting on @DamonU2)

---

packages/geoview-core/src/api/api.ts line 61 at r2 (raw file):

  /**
   * Sets a map viewer in maps.

Missing JSDOC params. Put a bit more info to say were this is called to add and delete map. Plus a TODO to create get later (with huge impact on current users)

[jolevesq]

Reviewable status: 2 of 4 files reviewed, 2 unresolved discussions (waiting on @DamonU2)

---

packages/geoview-core/src/core/app-start.tsx line 75 at r2 (raw file):

    // create a new map viewer instance and add it to the api
    // TODO: use store, remove the use of feature by viewer class and use state to gather values
    if (!(mapId in api.maps)) {

Even this check can be in api, what do you think

[jolevesq]

Reviewable status: 2 of 4 files reviewed, 2 unresolved discussions (waiting on @DamonU2)

---

packages/geoview-core/src/core/app-start.tsx line 75 at r2 (raw file):

Previously, jolevesq (Johann Levesque) wrote…

Even this check can be in api, what do you think

or will it create problem.... it can stay as is and we can deal when we have the getter

[DamonU2]

Reviewable status: 2 of 4 files reviewed, 2 unresolved discussions (waiting on @jolevesq)

---

packages/geoview-core/src/core/app-start.tsx line 75 at r2 (raw file):

Previously, jolevesq (Johann Levesque) wrote…

or will it create problem.... it can stay as is and we can deal when we have the getter

We can move all of this to a function in the API or leave it as is. We need the check here so that we don't create a MapViewer if we don't need it, but moving all of this to the API makes sense too.

[DamonU2]

Reviewable status: 2 of 4 files reviewed, 2 unresolved discussions (waiting on @DamonU2 and @jolevesq)

---

packages/geoview-core/src/api/api.ts line 61 at r2 (raw file):

Previously, jolevesq (Johann Levesque) wrote…

Missing JSDOC params. Put a bit more info to say were this is called to add and delete map. Plus a TODO to create get later (with huge impact on current users)

Done.

[jolevesq]

Reviewed 1 of 4 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @DamonU2)