feat(plugins): Hides plugin tabs if no layers support them

[DamonU2]

Closes #2369

Description

Removes (hides) tabs for time slider and geochart from footer-bar if there are no layers that support them. Also adds name and email to type action to stabilize it, and span tags to buttons to avoid errors when they are disabled.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

https://damonu2.github.io/geoview/demos-navigator.html?config=./configs/navigator/10-package-time-slider.json
https://damonu2.github.io/geoview/demos-navigator.html?config=./configs/navigator/12-package-geochart.json
https://damonu2.github.io/geoview/add-layers.html

Checklist:

• I have build (rush build) and deploy (rush host) my PR
• I have connected the issues(s) to this PR
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• My changes generate no new warnings
• I have created new issue(s) related to the outcome of this PR is needed
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

---

This change is 

[jolevesq]

Reviewed 12 of 12 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Alex-NRCan, @DamonU2, and @kaminderpal)

---

packages/geoview-core/src/api/event-processors/event-processor-children/ui-event-processor.ts line 50 at r1 (raw file):

  static addHiddenTab(mapId: string, tab: string): void {
    if (!this.getUIState(mapId).hiddenTabs.includes(tab))
      this.getUIState(mapId).setterActions.setHiddenTabs([...this.getUIState(mapId).hiddenTabs, tab]);

Maybe rename getUIState to getUIStateProtected like in other processor

[DamonU2]

Reviewable status: 10 of 12 files reviewed, 1 unresolved discussion (waiting on @Alex-NRCan, @jolevesq, and @kaminderpal)

---

packages/geoview-core/src/api/event-processors/event-processor-children/ui-event-processor.ts line 50 at r1 (raw file):

Previously, jolevesq (Johann Levesque) wrote…

Maybe rename getUIState to getUIStateProtected like in other processor

Done.

[kaminderpal]

Reviewable status: 10 of 12 files reviewed, 3 unresolved discussions (waiting on @Alex-NRCan, @DamonU2, and @jolevesq)

---

packages/geoview-core/src/ui/icon-button/icon-button.tsx line 35 at r1 (raw file):

  function getMaterialIconButton(): JSX.Element {
    return (
      <span>

We dnt use span/html element directly, we leverage Material UI Box component.

Also please make sure, it doesn't break any functionality, i dnt remember fully, their was reason to remove span tag.

Code snippet:

<Box component="span">
</Box>

---

packages/geoview-core/src/ui/icon-button/icon-button.tsx line 51 at r1 (raw file):

          {children && children}
        </MaterialIconButton>
      </span>

Same span issue above.

[Alex-NRCan]

Reviewed 10 of 12 files at r1, 2 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @DamonU2 and @jolevesq)

---

packages/geoview-core/src/ui/button/button.tsx line 45 at r3 (raw file):

  return (
    <Tooltip title={t(tooltip || '')} placement={tooltipPlacement || 'bottom'} TransitionComponent={Fade}>
      <span>

Same comment from Kamy below for this line here

[Alex-NRCan]

Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @DamonU2 and @jolevesq)

---

packages/geoview-core/src/api/event-processors/event-processor-children/time-slider-event-processor.ts line 91 at r3 (raw file):

    // Make sure tab is visible
    UIEventProcessor.removeHiddenTab(mapId, 'time-slider');

Minor
I understand why it was coded the way it is and all. Makes sense.
That said, from an outsider perspective, reading 'remove hidden' is a bit weird as it's a bit like a double negation.
Suggestion to see if it couldn't be more like a tab visibility flag? visible/invisible.
showTab()
hideTab()
kind of functions?

[DamonU2]

Reviewable status: 7 of 15 files reviewed, 4 unresolved discussions (waiting on @Alex-NRCan, @DamonU2, @jolevesq, and @kaminderpal)

---

packages/geoview-core/src/api/event-processors/event-processor-children/time-slider-event-processor.ts line 91 at r3 (raw file):

Previously, Alex-NRCan (Alex) wrote…

Minor
I understand why it was coded the way it is and all. Makes sense.
That said, from an outsider perspective, reading 'remove hidden' is a bit weird as it's a bit like a double negation.
Suggestion to see if it couldn't be more like a tab visibility flag? visible/invisible.
showTab()
hideTab()
kind of functions?

Done

---

packages/geoview-core/src/ui/button/button.tsx line 45 at r3 (raw file):

Previously, Alex-NRCan (Alex) wrote…

Same comment from Kamy below for this line here

Done.

---

packages/geoview-core/src/ui/icon-button/icon-button.tsx line 35 at r1 (raw file):

Previously, kaminderpal (Kamy) wrote…

We dnt use span/html element directly, we leverage Material UI Box component.

Also please make sure, it doesn't break any functionality, i dnt remember fully, their was reason to remove span tag.

Done.

---

packages/geoview-core/src/ui/icon-button/icon-button.tsx line 51 at r1 (raw file):

Previously, kaminderpal (Kamy) wrote…

Same span issue above.

Done.

[jolevesq]

Reviewed 1 of 2 files at r2, 1 of 1 files at r3, 8 of 8 files at r4, 3 of 3 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Alex-NRCan)