Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(basemap): satellite basemap added #2368

Merged

Conversation

DamonU2
Copy link
Member

@DamonU2 DamonU2 commented Jul 11, 2024

Closes #1849

Description

Added a satellite image basemap to basemap options and included it in the default basemap panel.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

https://damonu2.github.io/geoview/demos-navigator.html?config=./configs/navigator/08-package-basemap.json

Checklist:

  • I have build (rush build) and deploy (rush host) my PR
  • I have connected the issues(s) to this PR
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have created new issue(s) related to the outcome of this PR is needed
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

This change is Reviewable

@DamonU2 DamonU2 requested a review from jolevesq July 11, 2024 21:35
@DamonU2 DamonU2 self-assigned this Jul 11, 2024
@jolevesq jolevesq requested a review from Alex-NRCan July 12, 2024 12:40
Copy link
Member

@jolevesq jolevesq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 8 of 10 files at r1, all commit messages.
Reviewable status: 8 of 10 files reviewed, 1 unresolved discussion (waiting on @Alex-NRCan and @DamonU2)


packages/geoview-basemap-panel/schema.json line 98 at r1 (raw file):

          "type": "string",
          "description": "the basemap id",
          "enum": ["transport", "simple", "shaded", "osm", "nogeom", "satellite"]

I would call it imagery instead of satellite .... but in French Imagerie is not that good.

Copy link
Member

@Alex-NRCan Alex-NRCan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @DamonU2)


packages/geoview-basemap-panel/src/basemap-panel.tsx line 108 at r1 (raw file):

            (myMap.basemap.basemapsList[projection].satellite?.url as string)
              .replace('{z}', '8')
              .replace('{y}', projection === 3978 ? '285' : '91')

Suggestion to comment what those numbers mean and maybe put them as constants somewhere in the component?

@DamonU2 DamonU2 force-pushed the 1849-satellite-basemap branch from 0dbde26 to 99f3682 Compare July 12, 2024 13:59
@DamonU2 DamonU2 force-pushed the 1849-satellite-basemap branch from 99f3682 to 33c77a1 Compare July 12, 2024 14:23
Copy link
Member Author

@DamonU2 DamonU2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 11 files reviewed, 2 unresolved discussions (waiting on @Alex-NRCan, @DamonU2, and @jolevesq)


packages/geoview-basemap-panel/schema.json line 98 at r1 (raw file):

Previously, jolevesq (Johann Levesque) wrote…

I would call it imagery instead of satellite .... but in French Imagerie is not that good.

Done.


packages/geoview-basemap-panel/src/basemap-panel.tsx line 108 at r1 (raw file):

Previously, Alex-NRCan (Alex) wrote…

Suggestion to comment what those numbers mean and maybe put them as constants somewhere in the component?

Done.

@jolevesq jolevesq merged commit 8d985e7 into Canadian-Geospatial-Platform:develop Jul 12, 2024
5 of 6 checks passed
@DamonU2 DamonU2 deleted the 1849-satellite-basemap branch July 12, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add satellite image basemap
3 participants