-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(basemap): satellite basemap added #2368
feat(basemap): satellite basemap added #2368
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 8 of 10 files at r1, all commit messages.
Reviewable status: 8 of 10 files reviewed, 1 unresolved discussion (waiting on @Alex-NRCan and @DamonU2)
packages/geoview-basemap-panel/schema.json
line 98 at r1 (raw file):
"type": "string", "description": "the basemap id", "enum": ["transport", "simple", "shaded", "osm", "nogeom", "satellite"]
I would call it imagery instead of satellite .... but in French Imagerie is not that good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @DamonU2)
packages/geoview-basemap-panel/src/basemap-panel.tsx
line 108 at r1 (raw file):
(myMap.basemap.basemapsList[projection].satellite?.url as string) .replace('{z}', '8') .replace('{y}', projection === 3978 ? '285' : '91')
Suggestion to comment what those numbers mean and maybe put them as constants somewhere in the component?
0dbde26
to
99f3682
Compare
99f3682
to
33c77a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 11 files reviewed, 2 unresolved discussions (waiting on @Alex-NRCan, @DamonU2, and @jolevesq)
packages/geoview-basemap-panel/schema.json
line 98 at r1 (raw file):
Previously, jolevesq (Johann Levesque) wrote…
I would call it imagery instead of satellite .... but in French Imagerie is not that good.
Done.
packages/geoview-basemap-panel/src/basemap-panel.tsx
line 108 at r1 (raw file):
Previously, Alex-NRCan (Alex) wrote…
Suggestion to comment what those numbers mean and maybe put them as constants somewhere in the component?
Done.
8d985e7
into
Canadian-Geospatial-Platform:develop
Closes #1849
Description
Added a satellite image basemap to basemap options and included it in the default basemap panel.
Type of change
How Has This Been Tested?
https://damonu2.github.io/geoview/demos-navigator.html?config=./configs/navigator/08-package-basemap.json
Checklist:
I have made corresponding changes to the documentationI have added tests that prove my fix is effective or that my feature worksNew and existing unit tests pass locally with my changesThis change is