-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2366 aoi UI implementation phase1 #2367
2366 aoi UI implementation phase1 #2367
Conversation
c649312
to
65bb295
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 4 files at r1, 3 of 4 files at r2, 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @guichoquette)
packages/geoview-aoi-panel/src/aoi-panel.tsx
line 1 at r4 (raw file):
// import { TypeBasemapProps } from 'geoview-core/src/geo/layer/basemap/basemap-types';
Remove all dead code.
packages/geoview-aoi-panel/src/aoi-panel.tsx
line 29 at r4 (raw file):
export function AoiPanel(props: AoiPanelProps): JSX.Element { // eslint-disable-next-line @typescript-eslint/no-unused-vars
Why do you have this eslint escape. If a variableis not use, remove from props
packages/geoview-aoi-panel/src/aoi-panel.tsx
line 49 at r4 (raw file):
tabIndex={0} className="aoiCardThumbnail" onClick={() => myMap.zoomToLngLatExtentOrCoordinate(aoiItem.extent, { maxZoom: 13 })}
CAn we try 14
packages/geoview-aoi-panel/src/area-of-interest-style.ts
line 53 at r4 (raw file):
width: '100%', overflow: 'hidden', border: '1px solid #ccc',
We use theme.palette.geoViewColor.xxx for color
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 3 of 5 files reviewed, 4 unresolved discussions (waiting on @jolevesq)
packages/geoview-aoi-panel/src/aoi-panel.tsx
line 1 at r4 (raw file):
Previously, jolevesq (Johann Levesque) wrote…
Remove all dead code.
Done.
packages/geoview-aoi-panel/src/aoi-panel.tsx
line 29 at r4 (raw file):
Previously, jolevesq (Johann Levesque) wrote…
Why do you have this eslint escape. If a variableis not use, remove from props
Done.
packages/geoview-aoi-panel/src/aoi-panel.tsx
line 49 at r4 (raw file):
Previously, jolevesq (Johann Levesque) wrote…
CAn we try 14
Done.
packages/geoview-aoi-panel/src/area-of-interest-style.ts
line 53 at r4 (raw file):
Previously, jolevesq (Johann Levesque) wrote…
We use theme.palette.geoViewColor.xxx for color
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: 3 of 5 files reviewed, 2 unresolved discussions (waiting on @guichoquette)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r5.
Reviewable status: 4 of 5 files reviewed, 2 unresolved discussions (waiting on @guichoquette)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r5.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @guichoquette)
f51566e
to
49c7560
Compare
e69b770
into
Canadian-Geospatial-Platform:develop
Description
I added UI functionalities to AOI. Strangely the URL image does not get displayed.
Fixes # (2366)
Type of change
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
I added 2 AOI to make sure both were appearing in the AOI panel.
URL for your deploy!
Checklist:
I have made corresponding changes to the documentationI have added tests that prove my fix is effective or that my feature worksNew and existing unit tests pass locally with my changesThis change is