Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migration(open-layers) - Migration of Open Layers from 9.1.0 to 9.2.4 #2250

Merged

Conversation

Alex-NRCan
Copy link
Member

@Alex-NRCan Alex-NRCan commented Jun 13, 2024

Description

This PR is dependent on PR #2245
This PR migrates Open Layers from 9.1.0 to 9.2.4.
This fixes some issues some people have been getting with, for example, VectorSource in the GeometryApi class.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Hosted, June 28th, 12h: https://alex-nrcan.github.io/geoview/

Checklist:

  • I have build (rush build) and deploy (rush host) my PR
  • I have connected the issues(s) to this PR
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have created new issue(s) related to the outcome of this PR is needed
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

This change is Reviewable

@Alex-NRCan Alex-NRCan self-assigned this Jun 13, 2024
@Alex-NRCan Alex-NRCan force-pushed the feat-rush-update-ol branch from d684144 to 88de8c9 Compare June 14, 2024 13:46
@Alex-NRCan Alex-NRCan force-pushed the feat-rush-update-ol branch 2 times, most recently from ec25066 to 0996da8 Compare June 28, 2024 15:37
@Alex-NRCan Alex-NRCan force-pushed the feat-rush-update-ol branch from 0996da8 to b3496e1 Compare June 28, 2024 15:39
@Alex-NRCan Alex-NRCan marked this pull request as ready for review June 28, 2024 15:58
Copy link
Member

@jolevesq jolevesq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 11 of 11 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Alex-NRCan)

@jolevesq jolevesq merged commit 91f4ad2 into Canadian-Geospatial-Platform:develop Jun 28, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants