Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI improvements hover tooltip #2150

Conversation

cphelefu
Copy link
Contributor

@cphelefu cphelefu commented May 16, 2024

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #2141
Fixes #2151
Fixes #2152
Fixes #2153

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

https://cphelefu.github.io/geoview/

Checklist:

  • I have build (rush build) and deploy (rush host) my PR
  • I have connected the issues(s) to this PR
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have created new issue(s) related to the outcome of this PR is needed
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

This change is Reviewable

@cphelefu cphelefu marked this pull request as ready for review May 17, 2024 14:36
Copy link
Contributor

@kaminderpal kaminderpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 18 files reviewed, 2 unresolved discussions (waiting on @cphelefu)


packages/geoview-core/src/core/components/common/layer-icon.tsx line 26 at r1 (raw file):

  const iconData = useIconLayerSet(layerPath);

  const iconImage: string = iconData && iconData.length > 0 ? iconData[0] : '';

iconData && iconData.length can be written as iconData?.length same what we have for variable numOfIcons


packages/geoview-core/src/core/components/hover-tooltip/hover-tooltip.tsx line 14 at r1 (raw file):

 * @returns {JSX.Element} the hover tooltip component
 */
export function HoverTooltip(): JSX.Element {

why we remove return type.

Copy link
Contributor Author

@cphelefu cphelefu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 22 files reviewed, 2 unresolved discussions (waiting on @kaminderpal)


packages/geoview-core/src/core/components/common/layer-icon.tsx line 26 at r1 (raw file):

Previously, kaminderpal (Kamy) wrote…

iconData && iconData.length can be written as iconData?.length same what we have for variable numOfIcons

Done.


packages/geoview-core/src/core/components/hover-tooltip/hover-tooltip.tsx line 14 at r1 (raw file):

Previously, kaminderpal (Kamy) wrote…

why we remove return type.

Done.

Copy link
Contributor

@kaminderpal kaminderpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 18 files at r1, 14 of 17 files at r2, 2 of 3 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @cphelefu)

Copy link
Member

@jolevesq jolevesq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 18 files at r1, 14 of 17 files at r2, 2 of 3 files at r3, 1 of 1 files at r4, 1 of 1 files at r5, 2 of 2 files at r6, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @cphelefu)

@jolevesq jolevesq merged commit da7d45b into Canadian-Geospatial-Platform:develop May 21, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants