fix(UI): refactor appbar component #closes2145

[kaminderpal]

Description

Refactor UI Components.

1. Appbar
2. Attribution
3. Click Marker
4. Common
5. Crosshair

Fixes #2145

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Add the URL for your deploy!
https://kaminderpal.github.io/geoview/demos-navigator.html?config=./configs/navigator/07-basic-appbar.json
https://kaminderpal.github.io/geoview/demos-navigator.html?config=./configs/navigator/06-basic-footer.json

Checklist:

• I have build (rush build) and deploy (rush host) my PR
• I have connected the issues(s) to this PR
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• My changes generate no new warnings
• I have created new issue(s) related to the outcome of this PR is needed
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

---

This change is 

[jolevesq]

Reviewed all commit messages.
Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions (waiting on @kaminderpal)

---

packages/geoview-core/src/core/components/app-bar/app-bar.tsx line 50 at r1 (raw file):

  const { api: appBarApi } = props;

  const appBarTabRefs = useRef(['legend', 'details', 'guide']);

I think we have a constant or a type for this info in config (TypeValidAppBarCoreProps). If we need a constant we should create it in config-constant.ts

---

packages/geoview-core/src/core/components/app-bar/app-bar.tsx line 231 at r1 (raw file):

    }
    // eslint-disable-next-line react-hooks/exhaustive-deps
  }, [activeAppBarPanelId]);

For naming convention, appBar schema use tabs and at some places it is appBarTabs.... should we have activeAppBarTabId?

[kaminderpal]

Reviewable status: 0 of 18 files reviewed, 2 unresolved discussions (waiting on @jolevesq)

---

packages/geoview-core/src/core/components/app-bar/app-bar.tsx line 50 at r1 (raw file):

Previously, jolevesq (Johann Levesque) wrote…

I think we have a constant or a type for this info in config (TypeValidAppBarCoreProps). If we need a constant we should create it in config-constant.ts

Done.

---

packages/geoview-core/src/core/components/app-bar/app-bar.tsx line 231 at r1 (raw file):

Previously, jolevesq (Johann Levesque) wrote…

For naming convention, appBar schema use tabs and at some places it is appBarTabs.... should we have activeAppBarTabId?

Done.

[cphelefu]

Reviewable status: 0 of 18 files reviewed, 2 unresolved discussions (waiting on @jolevesq)

[jolevesq]

Reviewed 1 of 1 files at r2, 1 of 1 files at r3, 16 of 16 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @kaminderpal)

---

packages/geoview-core/src/core/components/app-bar/app-bar.tsx line 296 at r4 (raw file):

  /**
   * Re-order the footer tab buttons.

Is it footer or appBar

[kaminderpal]

Reviewable status: 17 of 18 files reviewed, 1 unresolved discussion (waiting on @jolevesq)

---

packages/geoview-core/src/core/components/app-bar/app-bar.tsx line 296 at r4 (raw file):

Previously, jolevesq (Johann Levesque) wrote…

Is it footer or appBar

Done.

[jolevesq]

Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @kaminderpal)

[jolevesq]

Reviewed 1 of 1 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @kaminderpal)