Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(map): implement mapsize in sandbox page #closes2102 #2116

Merged

Conversation

kaminderpal
Copy link
Contributor

@kaminderpal kaminderpal commented May 9, 2024

Description

Implement map size width and height input fields on sandbox for rendering different size of maps.

Fixes #2102

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Add the URL for your deploy!
https://kaminderpal.github.io/geoview/sandbox.html

Checklist:

  • I have build (rush build) and deploy (rush host) my PR
  • I have connected the issues(s) to this PR
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have created new issue(s) related to the outcome of this PR is needed
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

This change is Reviewable

Copy link
Member

@jolevesq jolevesq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r1, all commit messages.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @kaminderpal)


packages/geoview-core/public/templates/sandbox.html line 234 at r1 (raw file):

      newDiv.setAttributeNode(a);

      let mapWidth = document.getElementById("mapWidth")?.value;

use single quote here and all other places

Copy link
Contributor Author

@kaminderpal kaminderpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion (waiting on @jolevesq)


packages/geoview-core/public/templates/sandbox.html line 234 at r1 (raw file):

Previously, jolevesq (Johann Levesque) wrote…

use single quote here and all other places

Done.

@jolevesq jolevesq merged commit 3d305bb into Canadian-Geospatial-Platform:develop May 10, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] <Implement different map size in Configs Selector>
2 participants