Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1866-BUG-Bad_feature_info_propagation_to_store #1868

Conversation

ychoquet
Copy link
Contributor

@ychoquet ychoquet commented Feb 27, 2024

Description

Modifications to the feature-info-event-processor and the legends-layer-set files to resolve the propagation issue. The problem was that the queryable flag of a layer, if not set in the config file, was known only when the metadata were loaded. At that point in time, the registration of the queryable layers from the config file was done, but those relying on the metadata were never registered. A call to registerToLayerSets was added in the LegendsLayerSet instance to register those layers when the metadata are loded.

Fixes #1866

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

As usual, using the Chrome Devtools

Deploy URL: https://ychoquet.github.io/GeoView/all-layers.html

Checklist:

  • I have build (rush build) and deploy (rush host) my PR
  • I have connected the issues(s) to this PR
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have created new issue(s) related to the outcome of this PR is needed
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

This change is Reviewable

@ychoquet ychoquet force-pushed the 1866-BUG-Bad_feature_info_propagation_to_store branch from 78fbce4 to 4653a24 Compare February 28, 2024 05:46
@ychoquet ychoquet force-pushed the 1866-BUG-Bad_feature_info_propagation_to_store branch from 4653a24 to f5c19e9 Compare February 28, 2024 05:52
Copy link
Member

@jolevesq jolevesq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ychoquet)

@jolevesq jolevesq merged commit 4bc98b7 into Canadian-Geospatial-Platform:develop Feb 28, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Bad feature info propagation to store
2 participants