Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(click-static-map) Prevents click/hover queries on a static map #1864

Conversation

Alex-NRCan
Copy link
Member

@Alex-NRCan Alex-NRCan commented Feb 27, 2024

Description

Prevents click/hover queries on a static map

Fixes #1768

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Hosted here as of Feb 28 13h45 : https://alex-nrcan.github.io/geoview/sandbox.html

Checklist:

  • I have build (rush build) and deploy (rush host) my PR
  • I have connected the issues(s) to this PR
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have created new issue(s) related to the outcome of this PR is needed
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

This change is Reviewable

@Alex-NRCan Alex-NRCan self-assigned this Feb 27, 2024
@Alex-NRCan Alex-NRCan force-pushed the fix-prevent-click-static-map branch 3 times, most recently from 9ce86ca to ee3bde4 Compare February 28, 2024 17:47
@Alex-NRCan Alex-NRCan marked this pull request as ready for review February 28, 2024 17:49
Finished
@Alex-NRCan Alex-NRCan force-pushed the fix-prevent-click-static-map branch from ee3bde4 to 78be00a Compare February 28, 2024 18:27
Copy link
Member

@jolevesq jolevesq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 5 files at r1, 3 of 5 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Alex-NRCan)

@jolevesq jolevesq merged commit 7e6725d into Canadian-Geospatial-Platform:develop Feb 28, 2024
6 checks passed
@Alex-NRCan Alex-NRCan deleted the fix-prevent-click-static-map branch February 28, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Prevent User Click Static Map
2 participants