-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(geocore): refactor layerOrder to keep geocore in proper order #1861
fix(geocore): refactor layerOrder to keep geocore in proper order #1861
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 11 of 11 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @jolevesq)
fa89bef
to
a7b5cbd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 10 files at r2, all commit messages.
Reviewable status: 7 of 14 files reviewed, all discussions resolved (waiting on @Alex-NRCan)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 7 of 14 files reviewed, all discussions resolved (waiting on @Alex-NRCan)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 10 files at r2.
Reviewable status: 8 of 14 files reviewed, all discussions resolved (waiting on @Alex-NRCan)
a7b5cbd
to
35f9d20
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 11 files at r1.
Reviewable status: 8 of 14 files reviewed, all discussions resolved (waiting on @Alex-NRCan)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 11 files at r1, 6 of 10 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @DamonU2)
14ee7df
to
c3dbc10
Compare
c3dbc10
to
60e6e4d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 11 of 11 files at r3, 5 of 5 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @DamonU2)
c818df0
into
Canadian-Geospatial-Platform:develop
Closes #1852
Description
Layer order now maintains geocore layers in the proper location when they switch to the actual layer type.
Type of change
How Has This Been Tested?
https://damonu2.github.io/geoview/all-layers.html
https://damonu2.github.io/geoview/geocore.html
Checklist:
I have made corresponding changes to the documentationI have added tests that prove my fix is effective or that my feature worksNew and existing unit tests pass locally with my changesThis change is