Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(geocore): refactor layerOrder to keep geocore in proper order #1861

Conversation

DamonU2
Copy link
Member

@DamonU2 DamonU2 commented Feb 26, 2024

Closes #1852

Description

Layer order now maintains geocore layers in the proper location when they switch to the actual layer type.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

https://damonu2.github.io/geoview/all-layers.html
https://damonu2.github.io/geoview/geocore.html

Checklist:

  • I have build (rush build) and deploy (rush host) my PR
  • I have connected the issues(s) to this PR
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have created new issue(s) related to the outcome of this PR is needed
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

This change is Reviewable

@DamonU2 DamonU2 requested a review from jolevesq February 26, 2024 22:00
Copy link
Member

@Alex-NRCan Alex-NRCan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 11 of 11 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jolevesq)

@DamonU2 DamonU2 force-pushed the 1852-geocore-layer-structure branch 4 times, most recently from fa89bef to a7b5cbd Compare February 27, 2024 19:51
@DamonU2 DamonU2 marked this pull request as ready for review February 27, 2024 19:52
Copy link
Member

@jolevesq jolevesq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 10 files at r2, all commit messages.
Reviewable status: 7 of 14 files reviewed, all discussions resolved (waiting on @Alex-NRCan)

Copy link
Member

@jolevesq jolevesq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 7 of 14 files reviewed, all discussions resolved (waiting on @Alex-NRCan)

Copy link
Member

@jolevesq jolevesq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 10 files at r2.
Reviewable status: 8 of 14 files reviewed, all discussions resolved (waiting on @Alex-NRCan)

@DamonU2 DamonU2 force-pushed the 1852-geocore-layer-structure branch from a7b5cbd to 35f9d20 Compare February 27, 2024 20:40
Copy link
Member

@jolevesq jolevesq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 11 files at r1.
Reviewable status: 8 of 14 files reviewed, all discussions resolved (waiting on @Alex-NRCan)

Copy link
Member

@jolevesq jolevesq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 11 files at r1, 6 of 10 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @DamonU2)

@DamonU2 DamonU2 force-pushed the 1852-geocore-layer-structure branch 6 times, most recently from 14ee7df to c3dbc10 Compare February 28, 2024 16:46
@DamonU2 DamonU2 force-pushed the 1852-geocore-layer-structure branch from c3dbc10 to 60e6e4d Compare February 28, 2024 19:12
Copy link
Member

@jolevesq jolevesq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 11 of 11 files at r3, 5 of 5 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @DamonU2)

@jolevesq jolevesq merged commit c818df0 into Canadian-Geospatial-Platform:develop Feb 28, 2024
6 checks passed
@DamonU2 DamonU2 deleted the 1852-geocore-layer-structure branch February 28, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Geocore layers not following other layers structure
3 participants