feature(Swiper) - Using new Swiper store, small guide fix, better info logs, some other fixes and comments

[Alex-NRCan]

Description

Stores created
Style class created and separated from component
Fix for the path for the guide panel
Swiper, working state
Swiper improved
Moved the addEventListener and removeEventListener from the rendering phase to a useEffect mount hook.
Better logs and comments
Swiper working
Had to use async afterall to retrieve the OpenLayers layers
Adjusting the swiper template configs to use layer path
Finalizing
Cleanup

Fixes #1820

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Hosted here as of Feb. 26 15h: https://alex-nrcan.github.io/geoview/package-swiper.html

Checklist:

• I have build (rush build) and deploy (rush host) my PR
• I have connected the issues(s) to this PR
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• My changes generate no new warnings
• I have created new issue(s) related to the outcome of this PR is needed
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

---

This change is 

[jolevesq]

Reviewed 19 of 21 files at r1, 1 of 2 files at r2, all commit messages.
Reviewable status: 19 of 22 files reviewed, 6 unresolved discussions (waiting on @Alex-NRCan)

---

packages/geoview-core/src/api/event-processors/event-processor-children/swiper-event-processor.ts line 23 at r1 (raw file):

   * @returns An array of the subscriptions callbacks which were created
   */
  protected onInitialize(store: GeoviewStoreType): Array<() => void> | void {

I think the onInit method should be before the big block of comments as it is not static

---

packages/geoview-core/src/api/event-processors/event-processor-children/swiper-event-processor.ts line 81 at r1 (raw file):

  /**
   * Adds a swipe functionality to the specified map id and layer path

Typo swipe, should it be swiper?

---

packages/geoview-core/src/api/event-processors/event-processor-children/swiper-event-processor.ts line 111 at r1 (raw file):

  /**
   * Removes a swipe functionality for the specified map id and layer path

Typo swipe, should it be swiper?

---

packages/geoview-core/src/api/event-processors/event-processor-children/swiper-event-processor.ts line 141 at r1 (raw file):

  /**
   * Removes the swipe functionality for all layer paths

Typo swipe, should it be swiper?

---

packages/geoview-core/src/core/components/guide/guide-panel.tsx line 64 at r1 (raw file):

  // fetch the content of general guide items with custom hook
  let mdFilePath = '/geoview/public/locales/markdown/general-content.md';

Hum this should be relative to the location of main.js file.... ./locales/help/help.md We may need a specific issue if requires too much work

---

packages/geoview-core/src/geo/layer/layer.ts line 529 at r1 (raw file):

   * @returns {BaseLayer | LayerGroup} Returns the OpenLayer layer associated to the layer path.
   */
  getLayerByLayerPath = (layerPath: string): BaseLayer | LayerGroup => {

Should we call getOLLayer... to have ol in the name for clarity?

[Alex-NRCan]

Reviewable status: 16 of 22 files reviewed, 3 unresolved discussions (waiting on @Alex-NRCan and @jolevesq)

---

packages/geoview-core/src/api/event-processors/event-processor-children/swiper-event-processor.ts line 23 at r1 (raw file):

Previously, jolevesq (Johann Levesque) wrote…

I think the onInit method should be before the big block of comments as it is not static

True! Done.

---

packages/geoview-core/src/core/components/guide/guide-panel.tsx line 64 at r1 (raw file):

Previously, jolevesq (Johann Levesque) wrote…

Hum this should be relative to the location of main.js file.... ./locales/help/help.md We may need a specific issue if requires too much work

True, that might work. Let me try that in the host I'm doing when I push this.

---

packages/geoview-core/src/geo/layer/layer.ts line 529 at r1 (raw file):

Previously, jolevesq (Johann Levesque) wrote…

Should we call getOLLayer... to have ol in the name for clarity?

Yep, sounds good to me. Done.

[jolevesq]

Reviewed 6 of 6 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Alex-NRCan)

[jolevesq]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Alex-NRCan)

[jolevesq]

Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Alex-NRCan)