[FEATURE+FIX] GeoCore implementation update #1828

Alex-NRCan · 2024-02-19T21:40:08Z

Description

GeoCore implementation update
Add-Layer fix when adding GeoCore layer with uuid
GeoChart linkage with GeoCore

Fixes: #1214 #1499 #1742 #1806
Commented: #793
Related to: #43 #790

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

Hosted here as of Feb 19th 17h: https://alex-nrcan.github.io/geoview/

Checklist:

I have build (rush build) and deploy (rush host) my PR
I have connected the issues(s) to this PR
My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
My changes generate no new warnings
I have created new issue(s) related to the outcome of this PR is needed
~~I have made corresponding changes to the documentation~~
~~I have added tests that prove my fix is effective or that my feature works~~
~~New and existing unit tests pass locally with my changes~~

This change is

jolevesq

Reviewed 21 of 21 files at r1, 1 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @Alex-NRCan, @DamonU2, and @ychoquet)

packages/geoview-core/src/core/utils/config/config-validation.ts line 70 at r1 (raw file):

  // TODO: Refactor - Environment - How to edit this configuration easily per environment?
  /** The default geocore url */
  static CONFIG_GEOCORE_URL = 'https://geocore-stage.api.geo.ca';

To we should keep it packages\geoview-core\src\core\utils\constant.ts like other constant for the moment

packages/geoview-core/src/core/utils/config/reader/uuid-config-reader.ts line 26 at r1 (raw file):

import { logger } from '@/core/utils/logger';

// The GeoChart Json object coming out of the GeoCore response

Should packages configuration (i.e. gechart) as may not only be geocart

Or wrapped the whole type thing in a region with the package comment

packages/geoview-core/src/core/utils/config/reader/uuid-config-reader.ts line 326 at r1 (raw file):

    return listOfGeoviewLayerConfig;
  }

Wrap geochart config in a region

packages/geoview-core/src/core/utils/config/reader/uuid-config-reader.ts line 354 at r1 (raw file):

  /**
   * Generates GeoView layers and geocharts configurations, from GeoCore API, using a list of UUIDs.

package configuration (i.e. geochart)

packages/geoview-core/src/geo/layer/other/geocore.ts line 124 at r1 (raw file):

      // Generate the url
      // TODO: Check - Is the metadataAccessPath still used? Because it seems to be incompatible with the rest now?

It is but this is not he atttribute name when you call geocore url

DamonU2

Reviewed 20 of 21 files at r1, 1 of 2 files at r2, 1 of 1 files at r3.
Reviewable status: 20 of 22 files reviewed, 5 unresolved discussions (waiting on @Alex-NRCan, @jolevesq, and @ychoquet)

Alex-NRCan

Reviewed 1 of 2 files at r4, 5 of 5 files at r5, all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @jolevesq and @ychoquet)

packages/geoview-core/src/core/utils/config/config-validation.ts line 70 at r1 (raw file):