Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling layer actions #1506

Merged

Conversation

cphelefu
Copy link
Contributor

@cphelefu cphelefu commented Nov 16, 2023

Description

This PR adds the re-arrange and remove icons.
It focused more on iimplementing the delete with undo functionality.

Fixes #1255

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Add the URL for your deploy!

Checklist:

  • I have build (rush build) and deploy (rush host) my PR
  • I have connected the issues(s) to this PR
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have created new issue(s) related to the outcome of this PR is needed
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

This change is Reviewable

@cphelefu cphelefu force-pushed the handling-layer-actions branch 2 times, most recently from d5eed61 to 9f50046 Compare November 17, 2023 21:21
@cphelefu cphelefu force-pushed the handling-layer-actions branch from 6810d0f to e02091b Compare November 21, 2023 16:12
@cphelefu cphelefu marked this pull request as ready for review November 21, 2023 16:13
Copy link
Member

@jolevesq jolevesq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 12 of 18 files at r1, 8 of 8 files at r2, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @cphelefu)


packages/geoview-core/src/core/components/layers/layers.tsx line 67 at r2 (raw file):

        <Paper sx={{ padding: '20px' }}>
          <h3>Removing layers</h3>
          <Box sx={{ display: 'flex', flexDirection: 'row', alignItems: 'center' }}>

Style is duplicated, can it be in the style.ts file


packages/geoview-core/src/core/components/layers/layers.tsx line 69 at r2 (raw file):

          <Box sx={{ display: 'flex', flexDirection: 'row', alignItems: 'center' }}>
            <IconButton>
              <DeleteIcon style={{ fill: '#a9a9a9' }} />

Style is duplicated, can it be in the style.ts file


packages/geoview-core/src/core/components/layers/left-panel/delete-undo-button.tsx line 68 at r2 (raw file):

    if (inUndoState) {
      const timer = setInterval(() => {
        setProgress((prevProgress) => (prevProgress >= 100 ? 0 : prevProgress + 10));

Can we put progress + 5?


packages/geoview-core/src/core/components/layers/left-panel/single-layer.tsx line 135 at r2 (raw file):

      return (
        <IconButton onClick={handleReArrangeLayer}>
          <HandleIcon style={{ fill: '#c51e3a' }} />

Should this be a value reusable store in style.ts?

Copy link
Contributor Author

@cphelefu cphelefu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 17 of 18 files reviewed, 4 unresolved discussions (waiting on @jolevesq)


packages/geoview-core/src/core/components/layers/layers.tsx line 67 at r2 (raw file):

Previously, jolevesq (Johann Levesque) wrote…

Style is duplicated, can it be in the style.ts file

Done.


packages/geoview-core/src/core/components/layers/layers.tsx line 69 at r2 (raw file):

Previously, jolevesq (Johann Levesque) wrote…

Style is duplicated, can it be in the style.ts file

Done.


packages/geoview-core/src/core/components/layers/left-panel/delete-undo-button.tsx line 68 at r2 (raw file):

Previously, jolevesq (Johann Levesque) wrote…

Can we put progress + 5?

Done.


packages/geoview-core/src/core/components/layers/left-panel/single-layer.tsx line 135 at r2 (raw file):

Previously, jolevesq (Johann Levesque) wrote…

Should this be a value reusable store in style.ts?

Done.

@cphelefu cphelefu force-pushed the handling-layer-actions branch from fe8c5f3 to d5cae3e Compare November 21, 2023 17:01
Copy link
Member

@jolevesq jolevesq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @cphelefu)

@jolevesq jolevesq merged commit 0300c9a into Canadian-Geospatial-Platform:develop Nov 21, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Legend] Implement ability to remove legend item
2 participants