-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handling layer actions #1506
Handling layer actions #1506
Conversation
d5eed61
to
9f50046
Compare
6810d0f
to
e02091b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 12 of 18 files at r1, 8 of 8 files at r2, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @cphelefu)
packages/geoview-core/src/core/components/layers/layers.tsx
line 67 at r2 (raw file):
<Paper sx={{ padding: '20px' }}> <h3>Removing layers</h3> <Box sx={{ display: 'flex', flexDirection: 'row', alignItems: 'center' }}>
Style is duplicated, can it be in the style.ts file
packages/geoview-core/src/core/components/layers/layers.tsx
line 69 at r2 (raw file):
<Box sx={{ display: 'flex', flexDirection: 'row', alignItems: 'center' }}> <IconButton> <DeleteIcon style={{ fill: '#a9a9a9' }} />
Style is duplicated, can it be in the style.ts file
packages/geoview-core/src/core/components/layers/left-panel/delete-undo-button.tsx
line 68 at r2 (raw file):
if (inUndoState) { const timer = setInterval(() => { setProgress((prevProgress) => (prevProgress >= 100 ? 0 : prevProgress + 10));
Can we put progress + 5?
packages/geoview-core/src/core/components/layers/left-panel/single-layer.tsx
line 135 at r2 (raw file):
return ( <IconButton onClick={handleReArrangeLayer}> <HandleIcon style={{ fill: '#c51e3a' }} />
Should this be a value reusable store in style.ts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 17 of 18 files reviewed, 4 unresolved discussions (waiting on @jolevesq)
packages/geoview-core/src/core/components/layers/layers.tsx
line 67 at r2 (raw file):
Previously, jolevesq (Johann Levesque) wrote…
Style is duplicated, can it be in the style.ts file
Done.
packages/geoview-core/src/core/components/layers/layers.tsx
line 69 at r2 (raw file):
Previously, jolevesq (Johann Levesque) wrote…
Style is duplicated, can it be in the style.ts file
Done.
packages/geoview-core/src/core/components/layers/left-panel/delete-undo-button.tsx
line 68 at r2 (raw file):
Previously, jolevesq (Johann Levesque) wrote…
Can we put progress + 5?
Done.
packages/geoview-core/src/core/components/layers/left-panel/single-layer.tsx
line 135 at r2 (raw file):
Previously, jolevesq (Johann Levesque) wrote…
Should this be a value reusable store in style.ts?
Done.
fe8c5f3
to
d5cae3e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @cphelefu)
0300c9a
into
Canadian-Geospatial-Platform:develop
Description
This PR adds the re-arrange and remove icons.
It focused more on iimplementing the delete with undo functionality.
Fixes #1255
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Add the URL for your deploy!
Checklist:
I have made corresponding changes to the documentationI have added tests that prove my fix is effective or that my feature worksNew and existing unit tests pass locally with my changesThis change is