Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1480-Bugs-With-New-Store-Strategy #1485

Conversation

ychoquet
Copy link
Contributor

@ychoquet ychoquet commented Nov 9, 2023

Description

Elimination of the phantom click and correction to the hover result sets overwriting the click result sets.

Fixes #1480

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Using the Chrome Devtools to trace and debug the raw-feature-info-1.html template.

URL for the deploy: https://ychoquet.github.io/GeoView/raw-feature-info-1.html

Checklist:

  • I have build (rush build) and deploy (rush host) my PR
  • I have connected the issues(s) to this PR
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • [] I have created new issue(s) related to the outcome of this PR is needed
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

This change is Reviewable

@ychoquet ychoquet force-pushed the 1480-Bugs-With-New-Store-Strategy branch from ea62b98 to c5ea7aa Compare November 9, 2023 21:17
@ychoquet ychoquet force-pushed the 1480-Bugs-With-New-Store-Strategy branch from c5ea7aa to b534c1e Compare November 9, 2023 21:23
Copy link
Member

@jolevesq jolevesq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, 4 of 4 files at r2.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @ychoquet)

Copy link
Member

@jolevesq jolevesq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ychoquet)

@jolevesq jolevesq merged commit 53ad436 into Canadian-Geospatial-Platform:develop Nov 9, 2023
5 checks passed
@ychoquet ychoquet deleted the 1480-Bugs-With-New-Store-Strategy branch January 11, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] New-Store-Strategy
2 participants