Added a new optional callback when the panel has completed transitioning and is fully opened #1368
Conversation
Alex-NRCan
force-pushed
the
feat-panel-opened-callback
branch
2 times, most recently
from
78bfcff to
fb505d5
Compare
There was a problem hiding this comment.
Reviewed 2 of 3 files at r1, 4 of 5 files at r2, all commit messages.
Reviewable status: 4 of 5 files reviewed, 1 unresolved discussion (waiting on @Alex-NRCan)
packages/geoview-core/src/ui/panel/panel.tsx line 104 at r2 (raw file):
* The transition period it takes for the panel to slide in */ const TRANSITION_PERIOD = 300;
If we put this constant in a new file in ui style and export it from there. We can reuse in theme and in this file. This way, we are sure theme is not modified and panel does not follow?
… transition Reworked panel opened handle Now using 'useTheme()' instead to set the transition value of the panel (originally was hardcoded to 300 in panel.tsx) AND to the callback timer using the value from the theme.
Alex-NRCan
force-pushed
the
feat-panel-opened-callback
branch
from
9ebffd0 to
f2c6454
Compare
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Alex-NRCan)
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @Alex-NRCan)
jolevesq
merged commit 54d5ed8
into
Canadian-Geospatial-Platform:develop
Description
For the purpose of using HTML canvas drawing (notably for the GeoChart), I needed to know when the panel has completed expanding, to force a redraw of the canvas. Of course, this PR focuses on implementing the callback logic without knowledge of the specific reason for the callback. It can serve other purposes too.
Type of change
How Has This Been Tested?
Tested as part of the GeoChart plugin.
Checklist:
I have made corresponding changes to the documentationI have added tests that prove my fix is effective or that my feature worksNew and existing unit tests pass locally with my changesThis change is