refactor(store): Refactor north arrow to use the store and remove api…

[jolevesq]

… from footer element

Closes #1329

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Add the URL for your deploy!

Checklist:

• I have build (rush build) and deploy (rush host) my PR
• I have connected the issues(s) to this PR
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• My changes generate no new warnings
• I have created new issue(s) related to the outcome of this PR is needed
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

---

This change is 

[DamonU2]

Reviewed 21 of 21 files at r1, all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @cphelefu, @jolevesq, and @ychoquet)

---

packages/geoview-core/src/api/eventProcessors/map-event-process.ts line 51 at r1 (raw file):

        // because emit and on from api events can be trigger in loop, compare also the api value
        if (cur !== prev && api.maps[mapId].currentProjection !== cur!) {
          console.log(`proj emit ${mapId}`);

"Disable no console for this line" to prevent flags?

---

packages/geoview-core/src/api/eventProcessors/map-event-process.ts line 84 at r1 (raw file):

        // because emit and on from api events can be trigger in loop, compare also the api value
        if (payloadIsAMapViewProjection(payload) && api.maps[mapId].currentProjection !== payload.projection!) {
          console.log(`proj on ${mapId}`);

As above

---

packages/geoview-core/src/core/components/overview-map/overview-map.tsx line 113 at r1 (raw file):

  /**
   * Return the map ovberview map

ovberview > overview

---

packages/geoview-core/src/core/stores/stores-managers.ts line 35 at r1 (raw file):

  initializeEventProcessors(geoViewStore);

  console.log('store creation');

Disable no console?

---

packages/geoview-core/src/geo/map/map.ts line 413 at r1 (raw file):

          this.map.getView().on('change:rotation', store.getState().mapState.onMapRotation);

          console.log('store add map event');

As above

[cphelefu]

Reviewed 21 of 21 files at r1, all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @jolevesq and @ychoquet)

[jolevesq]

Reviewed 7 of 13 files at r2.
Reviewable status: 19 of 25 files reviewed, 5 unresolved discussions (waiting on @cphelefu, @DamonU2, and @ychoquet)

---

packages/geoview-core/src/api/eventProcessors/map-event-process.ts line 51 at r1 (raw file):

Previously, DamonU2 (Damon Ulmi) wrote…

"Disable no console for this line" to prevent flags?

Done.

---

packages/geoview-core/src/api/eventProcessors/map-event-process.ts line 84 at r1 (raw file):

Previously, DamonU2 (Damon Ulmi) wrote…

As above

Done.

---

packages/geoview-core/src/core/components/overview-map/overview-map.tsx line 113 at r1 (raw file):

Previously, DamonU2 (Damon Ulmi) wrote…

ovberview > overview

Done.

---

packages/geoview-core/src/core/stores/stores-managers.ts line 35 at r1 (raw file):

Previously, DamonU2 (Damon Ulmi) wrote…

Disable no console?

Done.

---

packages/geoview-core/src/geo/map/map.ts line 413 at r1 (raw file):

Previously, DamonU2 (Damon Ulmi) wrote…

As above

Done.

[jolevesq]

Reviewed 14 of 21 files at r1, 4 of 13 files at r2, all commit messages.
Reviewable status: 23 of 25 files reviewed, 5 unresolved discussions (waiting on @cphelefu, @DamonU2, and @ychoquet)

[DamonU2]

Reviewed 2 of 13 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ychoquet)

[cphelefu]

packages/geoview-core/src/api/eventProcessors/notification-event-process.ts line 15 at r3 (raw file):

    api.event.on(
      EVENT_NAMES.NOTIFICATIONS.NOTIFICATION_ADD,
      (payload: PayloadBaseClass) => {

Why do we have this here? Where do we call this NOTIFICATION_ADD; why didnt we just add it to the store directly from there?

[cphelefu]

packages/geoview-core/src/core/components/map/map.tsx line 59 at r3 (raw file):

  // get values from the store
  const { mapLoaded, northArrow, overviewMap } = useStore(getGeoViewStore(mapId), (state) => state.mapState);

This is going to refresh page whenever any property in mapState is changed.
I think it should be (state) => [state.mapState.mapLoaded, state.mapState,northArrow ])..

Something along these lines, confirm in zustand documentation

[jolevesq]

Reviewed 14 of 14 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ychoquet)

[jolevesq]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @cphelefu and @ychoquet)

---

packages/geoview-core/src/api/eventProcessors/notification-event-process.ts line 15 at r3 (raw file):

Previously, cphelefu (Christopher Phelefu) wrote…

Why do we have this here? Where do we call this NOTIFICATION_ADD; why didnt we just add it to the store directly from there?

Because this event may be emit by the api from outside the viewer

[jolevesq]

Reviewed 1 of 13 files at r2.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @cphelefu and @ychoquet)

[jolevesq]

Reviewed 1 of 1 files at r4.
Reviewable status: all files reviewed (commit messages unreviewed), 2 unresolved discussions (waiting on @cphelefu and @ychoquet)

---

packages/geoview-core/src/core/components/map/map.tsx line 59 at r3 (raw file):

Previously, cphelefu (Christopher Phelefu) wrote…

This is going to refresh page whenever any property in mapState is changed.
I think it should be (state) => [state.mapState.mapLoaded, state.mapState,northArrow ])..

Something along these lines, confirm in zustand documentation

Done.

[jolevesq]

Reviewed all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @cphelefu and @ychoquet)

[cphelefu]

Reviewed 8 of 13 files at r2, 13 of 14 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ychoquet)

[cphelefu]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ychoquet)

[jolevesq]

Reviewed 1 of 21 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ychoquet)