Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1149-getAllFeatureInfo #1356

Merged

Conversation

ychoquet
Copy link
Contributor

@ychoquet ychoquet commented Oct 4, 2023

Description

This PR adds the possibility to send get all feature info queries to the vector layers.

Fixes #1149 Link getAllFesureInfo to the layerSets

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

In the templates, follow the link type of layers and then, any vector layer. A new section Get All Feature Info has been added to the bottom of the map. When you click on it, the query is launched and when the result comes back, it is displayed in the extended box created.

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
As usual, I used the Chrome Devtools to trace, verify and debbug the code.

Deploy URL: https://ychoquet.github.io/GeoView/type-of-layers.html

Checklist:

  • I have build (rush build) and deploy (rush host) my PR
  • I have connected the issues(s) to this PR
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have created new issue(s) related to the outcome of this PR is needed
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

This change is Reviewable

@ychoquet ychoquet marked this pull request as ready for review October 4, 2023 17:23
@ychoquet ychoquet force-pushed the 1149-getAllFesureInfo branch 19 times, most recently from 849452c to b7629bc Compare October 7, 2023 02:40
@ychoquet ychoquet force-pushed the 1149-getAllFesureInfo branch from b7629bc to ea85848 Compare October 7, 2023 19:09
Copy link
Member

@jolevesq jolevesq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 80 of 88 files at r1, 1 of 2 files at r2, 1 of 1 files at r3, 2 of 2 files at r4, 5 of 5 files at r5, 4 of 4 files at r6, 10 of 26 files at r7, 29 of 29 files at r8, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ychoquet)

@jolevesq jolevesq merged commit d2f4745 into Canadian-Geospatial-Platform:develop Oct 10, 2023
5 checks passed
@ychoquet ychoquet deleted the 1149-getAllFesureInfo branch January 11, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Link getAllFesureInfo to the layerSets
2 participants