-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(DataTable): datatable language Closes #1309 #1353
fix(DataTable): datatable language Closes #1309 #1353
Conversation
…form/geoview into 1309-datatable-language
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 6 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @kaminderpal)
packages/geoview-core/src/core/components/data-table/map-data-table.tsx
line 136 at r2 (raw file):
const { t, i18n } = useTranslation(); const locale = i18n.language === 'fr' ? 'fr-ca' : 'en';
You should get language by api.maps[mapId].currentLanguage I think
packages/geoview-core/src/core/components/data-table/map-data-table.tsx
line 366 at r2 (raw file):
<DatePicker timezone="UTC" format={locale === 'fr-ca' ? 'DD/MM/YYYY' : 'YYYY-MM-DD'}
format should always be YYYY/MM/DD as it is the ISO format for date. For French it should be AAAA/MM/JJ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 5 of 6 files reviewed, 2 unresolved discussions (waiting on @jolevesq)
packages/geoview-core/src/core/components/data-table/map-data-table.tsx
line 136 at r2 (raw file):
Previously, jolevesq (Johann Levesque) wrote…
You should get language by api.maps[mapId].currentLanguage I think
Done.
packages/geoview-core/src/core/components/data-table/map-data-table.tsx
line 366 at r2 (raw file):
Previously, jolevesq (Johann Levesque) wrote…
format should always be YYYY/MM/DD as it is the ISO format for date. For French it should be AAAA/MM/JJ
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @kaminderpal)
a80ae30
into
Canadian-Geospatial-Platform:develop
Description
Update language of data table components like filter mode, filter message, toggle density.
Fixes # (1309)
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Add the URL for your deploy!
https://kaminderpal.github.io/geoview/raw-data-table.html
Checklist:
I have made corresponding changes to the documentationI have added tests that prove my fix is effective or that my feature worksNew and existing unit tests pass locally with my changesThis change is