-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESLinting support and some more options in template #4
Conversation
182fb77
to
3d441dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 13 of 15 files at r1, 1 of 1 files at r2.
Reviewable status: 13 of 15 files reviewed, 3 unresolved discussions (waiting on @Alex-NRCan)
.eslintrc
line 79 at r1 (raw file):
} }
Remove trailing whitespaces
src/chart.tsx
line 15 at r1 (raw file):
*/ export interface TypeChartChartProps<TType extends GeoChartType> { style?: unknown;
Better then any but still not the best. Can we reuse style type we have in Geoview?
src/chart-validator.ts
line 28 at r1 (raw file):
}; public SCHEMA_OPTIONS = {
In later PR this should be bring outside in a json file just for the thing we support. Let say we do not expose legend because it is always false, we can only deal with it from inside.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 15 files at r1.
Reviewable status: 14 of 15 files reviewed, 3 unresolved discussions (waiting on @Alex-NRCan)
b0a14e7
to
3e53015
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 14 of 15 files reviewed, 3 unresolved discussions (waiting on @jolevesq)
src/chart.tsx
line 15 at r1 (raw file):
Previously, jolevesq (Johann Levesque) wrote…
Better then any but still not the best. Can we reuse style type we have in Geoview?
Right. I wanted to type it as CSSProperties originally
, but that type comes from cgpv
which is loaded later in the JSX.Element. The style is casted there. Is there another solution?
src/chart-validator.ts
line 28 at r1 (raw file):
Previously, jolevesq (Johann Levesque) wrote…
In later PR this should be bring outside in a json file just for the thing we support. Let say we do not expose legend because it is always false, we can only deal with it from inside.
Will do and add an issue.
Added defaultProps back Fix it Spacing
0c4343f
to
103bebc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Alex-NRCan)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Alex-NRCan)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Alex-NRCan)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Alex-NRCan)
…orm/feat-ESLinting ESLinting support and some more options in template
…orm/feat-ESLinting ESLinting support and some more options in template
Now properly supporting ESLint and Prettier cloning configurations from geoview-core
This change is