Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLinting support and some more options in template #4

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

Alex-NRCan
Copy link
Member

@Alex-NRCan Alex-NRCan commented Oct 13, 2023

Now properly supporting ESLint and Prettier cloning configurations from geoview-core


This change is Reviewable

@Alex-NRCan Alex-NRCan requested a review from jolevesq October 13, 2023 14:16
@Alex-NRCan Alex-NRCan self-assigned this Oct 13, 2023
@Alex-NRCan Alex-NRCan changed the title Feat es linting ESLinting support and some more options in template Oct 13, 2023
@Alex-NRCan Alex-NRCan force-pushed the feat-ESLinting branch 2 times, most recently from 182fb77 to 3d441dd Compare October 17, 2023 13:30
Copy link
Member

@jolevesq jolevesq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 13 of 15 files at r1, 1 of 1 files at r2.
Reviewable status: 13 of 15 files reviewed, 3 unresolved discussions (waiting on @Alex-NRCan)


.eslintrc line 79 at r1 (raw file):

    }
  }
  

Remove trailing whitespaces


src/chart.tsx line 15 at r1 (raw file):

 */
export interface TypeChartChartProps<TType extends GeoChartType> {
  style?: unknown;

Better then any but still not the best. Can we reuse style type we have in Geoview?


src/chart-validator.ts line 28 at r1 (raw file):

  };

  public SCHEMA_OPTIONS = {

In later PR this should be bring outside in a json file just for the thing we support. Let say we do not expose legend because it is always false, we can only deal with it from inside.

Copy link
Member

@jolevesq jolevesq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 15 files at r1.
Reviewable status: 14 of 15 files reviewed, 3 unresolved discussions (waiting on @Alex-NRCan)

Copy link
Member Author

@Alex-NRCan Alex-NRCan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 14 of 15 files reviewed, 3 unresolved discussions (waiting on @jolevesq)


src/chart.tsx line 15 at r1 (raw file):

Previously, jolevesq (Johann Levesque) wrote…

Better then any but still not the best. Can we reuse style type we have in Geoview?

Right. I wanted to type it as CSSProperties originally, but that type comes from cgpv which is loaded later in the JSX.Element. The style is casted there. Is there another solution?


src/chart-validator.ts line 28 at r1 (raw file):

Previously, jolevesq (Johann Levesque) wrote…

In later PR this should be bring outside in a json file just for the thing we support. Let say we do not expose legend because it is always false, we can only deal with it from inside.

Will do and add an issue.

Added defaultProps back
Fix it
Spacing
Copy link
Member

@jolevesq jolevesq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Alex-NRCan)

Copy link
Member

@jolevesq jolevesq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Alex-NRCan)

Copy link
Member

@jolevesq jolevesq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Alex-NRCan)

Copy link
Member

@jolevesq jolevesq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Alex-NRCan)

@jolevesq jolevesq merged commit 76dd5e9 into develop Oct 17, 2023
github-actions bot pushed a commit that referenced this pull request Oct 17, 2023
…orm/feat-ESLinting

ESLinting support and some more options in template
github-actions bot pushed a commit that referenced this pull request Oct 17, 2023
…orm/feat-ESLinting

ESLinting support and some more options in template
@Alex-NRCan Alex-NRCan deleted the feat-ESLinting branch October 17, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants