The registering of the Chart.js elements can't be part of the useEffect #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct handle after all.
Alex-NRCan
merged commit b0d37ee
into
Canadian-Geospatial-Platform:develop
1 check failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The registering of the Chart.js elements can't be part of the useEffect handle after all.
Locally, the solution works, but when running from the build files, it seems the Chart.js registering runs 'too late' if it's done inside the useEffect().
Also, now using registerables which is a shortcut created by Chart.js instead of explicitly registering element by element.
This change is