Skip to content

Commit

Permalink
Update README.md
Browse files Browse the repository at this point in the history
  • Loading branch information
Alex-NRCan authored Sep 26, 2023
1 parent 414938e commit f5a04ed
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@ This project is the GeoChart Plugin offering chart and slider capabilities. Deve

IMPORTANT: This plugin uses react-chart-js which also has a react dependency. For compatibility reasons:
1) The [webpack.common.js](https://github.com/Canadian-Geospatial-Platform/geochart/blob/main/webpack.common.js#L22) file has property to exclude react and react-dom from the packages
![image](https://github.com/Canadian-Geospatial-Platform/geochart/assets/94073946/0559b31d-97bb-451c-bf8b-70c3a73991a5)
![image](https://github.com/Canadian-Geospatial-Platform/geochart/assets/94073946/0559b31d-97bb-451c-bf8b-70c3a73991a5)

2) cgpv-main.js in the [index.html](https://github.com/Canadian-Geospatial-Platform/geochart/blob/main/index.html#L16) file is referenced via the github url hostname (not the localhost, nor 127.0.0.1, nor an url tricked via the hosts file, etc) - any of those may result in react hook issues.
![image](https://github.com/Canadian-Geospatial-Platform/geochart/assets/94073946/9bbe481f-f51d-432c-a34a-f669dacaf87e)
![image](https://github.com/Canadian-Geospatial-Platform/geochart/assets/94073946/9bbe481f-f51d-432c-a34a-f669dacaf87e)

[Demo](https://canadian-geospatial-platform.github.io/geochart/)

Expand Down

0 comments on commit f5a04ed

Please sign in to comment.