Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and Features #85

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

Netzvamp
Copy link

@Netzvamp Netzvamp commented Nov 8, 2020

Hi,

i've looked into your Dockerfile as a base for my ticket system and found things to fix and needed some features i've added.

Here we go:

  • I've fixed the URLs to the translation files. The previous links where not for 1.14 but for a much older version!
    • While doing that i've found it ok to add all available languages to make it more useable for everybody
  • I've added all official and most of the inofficial plugins available
  • Added MYSQL_PASSWORD_FILE, INSTALL_SECRET_FILE, ADMIN_PASSWORD_FILE, SMTP_PASSWORD_FILE to provide secrets outside of env variables with paths to files.
    • This is required for docker secrets to work, they get mounted to /run/secrets as files
    • I've added an example for that in the docker-compose-swarm.yml
      • TODO: If you decide to merge this, replace my image (rlieback/osticket) with yours
  • I've extended the README with the new features
  • Cleanup in the Dockerfile:
    • I've fixed the deployment in the dockerfile, now only alpine is needed during build
      • Osticket and Alpine had some problems with listing files to copy to the upload folder, but osticket can be deployed with a git option as a workaround
    • I've added the php zip extension, cause the systeminfo in osticket says it would be good to have that for "ticket and task exporting"
  • I've removed the .idea folder, cause it's already in the .gitignore and it's just anoying if you use jetbrains products (imho)

With all things added the compressed image is only 5 MB greater than without all languages and plugins. Looks efficient for me...

I've tested it locally and in my swarm, but it could be nice to have some other use cases tested

Greetings, Robert

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant