Skip to content

Commit

Permalink
refs #272 fixing typography and code standard
Browse files Browse the repository at this point in the history
  • Loading branch information
Peter Moraes committed Aug 2, 2016
1 parent 56e76b7 commit 9a78bf5
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 8 deletions.
2 changes: 1 addition & 1 deletion Console/Command/MigrationShell.php
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ public function getOptionParser() {
'help' => __('Skip certain migration.')))
->addOption('jump-to', array(
'short' => 'j',
'help' => __('Will jump to the migration and mark the others as executed.')))
'help' => __('Jump to a certain migration and mark the preceding migrations as executed.')))
->addOption('compare', array(
'short' => 'm',
'boolean' => true,
Expand Down
2 changes: 1 addition & 1 deletion Docs/Documentation/Examples.md
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ Remember this migrations will be set as executed.
Jumping to certain migrations
--------------------------------------------------

If you want to jump to certain migration, you can use ```--jump-to``` or ```-j``` + migration name as the example below.
If you want to jump to a certain migration, you can use ```--jump-to``` or ```-j``` + migration name as in the example below.

```
cake Migrations.migration run all -j 1458963215_articles_table
Expand Down
9 changes: 5 additions & 4 deletions Lib/MigrationVersion.php
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ class MigrationVersion {
public $skip = array();

/**
* Will jump to the migration.
* Jump to a certain migration.
*
* @var null|string
*/
Expand Down Expand Up @@ -406,10 +406,10 @@ public function run($options) {
}

/**
* jump method
* Jump to a certain migration and mark the preceding migrations as executed.
*
* @param array $version version of a migration
* @param array $info migration info
* @param array $version Version of a migration to jump to.
* @param array $type migration type
* @return void
*/
public function jump($version, $type) {
Expand All @@ -419,6 +419,7 @@ public function jump($version, $type) {
/**
* Will return a version based in the migration name
*
* @param array $mapping mapping of all migrations.
* @return bool|string
*/
public function getVersionByName($mapping) {
Expand Down
6 changes: 4 additions & 2 deletions Test/Case/Console/Command/MigrationShellTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,8 @@ public function testRun() {
'version' => 1,
'dry' => false,
'precheck' => null,
'skip' => array())));
'skip' => array()))
);
$this->Shell->args = array('up');
$this->assertTrue($this->Shell->run());

Expand All @@ -229,7 +230,8 @@ public function testRun() {
'version' => 1,
'dry' => false,
'precheck' => null,
'skip' => array())));
'skip' => array()))
);
$this->Shell->args = array('down');
$this->assertTrue($this->Shell->run());

Expand Down

0 comments on commit 9a78bf5

Please sign in to comment.