[CBRD-25768] Separate server requests to the master between the server and the client #5751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
H2SU
approved these changes
Dec 31, 2024
beyondykk9
reviewed
Jan 1, 2025
src/connection/connection_defs.h
Outdated
| SERVER_REQUEST_NEW = 5, /* new-style server request */ | ||
| SERVER_REQUEST_FROM_SERVER = 3, /* let new server attach */ | ||
| SERVER_REQUEST_FROM_CLIENT = 4, /* let new client process attach */ | ||
| UNUSED_REQUEST = 5, /* unused request - leave it for compatibility */ |
There was a problem hiding this comment.
호환성을 위해 유지해야 한다면, 5가 아니라 4로 유지해야 할 것 같습니다.
There was a problem hiding this comment.
UNUSED_REQUEST를 제거하여서 호환성을 유지하도록 변경하였습니다.
beyondykk9
reviewed
Jan 2, 2025
| } | ||
| else | ||
| { | ||
| proc_register = (CSS_SERVER_PROC_REGISTER *) buffer; |
There was a problem hiding this comment.
buffer가 NULL인지 체크할 필요가 있지 않나요?
There was a problem hiding this comment.
assertion을 추가하였습니다.
beyondykk9
reviewed
Jan 2, 2025
| proc_register = (CSS_SERVER_PROC_REGISTER *) buffer; | ||
| server_name = proc_register->server_name; | ||
| server_name_length = proc_register->server_name_length; | ||
| } | ||
| length = (int) strlen (server_name) + 1; |
There was a problem hiding this comment.
server_name이 NULL인 경우에 대해 처리가 필요할 것 같습니다.
There was a problem hiding this comment.
assertion을 추가하였습니다.
InChiJun
approved these changes
Jan 2, 2025
added 2 commits
January 2, 2025 14:33
beyondykk9
approved these changes
Jan 2, 2025
hornetmj
approved these changes
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://jira.cubrid.org/browse/CBRD-25768
Purpose
css_register_new_server는 새로운 server process의 정보를 받아, cub_master에 등록하는 함수css_accept_new_reqeust함수를 호출하여 packing 된 정보를 해체하여 cub_master에 정보를 등록한다. 이러한 상황은 두 가지로 분류된다.CSS_SERVER_PROC_REGISTER자료구조에 정보를 담아서 master에 정보를 보낸다.위 두 상황은 서로 다른 format임에도 불구하고, 같은 request code인
SERVER_REQUEST로 전송되고 있다.Implementation
SERVER_REQUEST_FROM_SERVERrequest를 통해 요청 전송SERVER_REQUEST_FROM_CLIENTrequest를 통해 요청 전송css_register_new_server와, 정보를 unpack 하는 함수인css_accept_new_reqeust에is_client변수를 추가로 받도록 변경하여, 다루고 있는 process가 client 인지 정보를 추가로 전달buffer를 그대로 server name으로 인식하고, server라면, 전달 받은buffer를CSS_SERVER_PROC_REGISTER로 변환하여 정보를 unpack 한다.