[CBRD-25756] Update initialization method for 'lang_str' #5741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@H2SU lang_string이 무엇인가요? |
lang_string은 en_US , ko_KR과 같은 locale을 이야기합니다. |
YeunjunLee
approved these changes
Dec 31, 2024
InChiJun
approved these changes
Jan 2, 2025
ctshim
approved these changes
Jan 2, 2025
hornetmj
reviewed
Jan 4, 2025
src/transaction/log_manager.c
Outdated
| db_make_int (&lang_str, 1); | ||
| db_make_null (&result); | ||
|
|
||
| lang_set_flag_from_lang (lang_str, has_user_format, has_user_lang, &flag); |
There was a problem hiding this comment.
Suggested change
| lang_set_flag_from_lang (lang_str, has_user_format, has_user_lang, &flag); | |
| lang_set_flag_from_lang (NULL, false, false, &flag); |
src/transaction/log_manager.c
Outdated
Comment on lines
13609
to
13610
| bool has_user_format = false; | ||
| bool has_user_lang = false; |
There was a problem hiding this comment.
Suggested change
| bool has_user_format = false; | |
| bool has_user_lang = false; |
src/transaction/log_manager.c
Outdated
| const char *src, *end; | ||
| char *lang_str = NULL; |
There was a problem hiding this comment.
Suggested change
| char *lang_str = NULL; |
hornetmj
reviewed
Jan 4, 2025
| @@ -13626,8 +13631,9 @@ cdc_put_value_to_loginfo (db_value * new_value, char **data_ptr) | |||
| const char *timestamp_frmt = "YYYY-MM-DD HH24:MI:SS"; | |||
| const char *timestamptz_frmt = "YYYY-MM-DD HH24:MI:SS TZH:TZM"; | |||
| const char *timestampltz_frmt = "YYYY-MM-DD HH24:MI:SS TZR"; | |||
| db_make_int (&lang_str, 1); | |||
| db_make_null (&result); | |||
There was a problem hiding this comment.
db_make_null (&result); 제거는 의도된 것인가요?
H2SU
force-pushed
the
CBRD-25756
branch
2 times, most recently
from
d779a8d to
4c47c38
Compare
hornetmj
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://jira.cubrid.org/browse/CBRD-25756
Purpose
에러를 return하도록 수정
checksum이 일치하지 않아 에러가 발생
주요 함수 및 변수
Implementation