Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CBRD-25184] Update answer for PL/CSQL phase-1 internal release #2004

Merged
merged 5 commits into from
Dec 23, 2024

Conversation

kimhak-tech
Copy link
Contributor

@@ -23,15 +23,17 @@ null


===================================================
0
Error:-493
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Precision and scale specifications are not allowed for argument types and return types. It is recommended to modify the SQL to enable normal execution.
http://jira.cubrid.org/browse/CBRD-25219?focusedCommentId=4767031&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-4767031

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

He saids
please modify to 'CREATE OR REPLACE function foo(a int) return char(3) AS' -> 'CREATE OR REPLACE function foo(a int) return char AS' on the sql/_05_plcsql/_01_testspec/_05_bug_fix/cases/13_false_rewriting.sql.
(not changed answer file)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!


null

Error:-494
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has been reported as a bug. It would be better to wait for the processing result.
Timestamp is also the same.
http://jira.cubrid.org/browse/CBRD-25750

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll discard the change of this file.

@@ -101,13 +101,12 @@ T_NUMERIC

===================================================
type_support_return(0.1)
0.100000000000000
0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has been reported as a bug. It would be better to wait for the processing result.
http://jira.cubrid.org/browse/CBRD-25690

Copy link
Contributor Author

@kimhak-tech kimhak-tech Dec 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll discard the changes of this part

type_support_return(9876543210987654321098.7654321098765432)
9876543210987654321098.765432109876543

Error:-427
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is recommended to modify the SQL to enable normal execution.
select type_support_return(9876543210987654321098.765432109876543);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you modify the .sql file, the .answer must also be modified.

@@ -101,13 +101,12 @@ T_NUMERIC

===================================================
type_support_return(0.1)
0.1000000000
0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has been reported as a bug. It would be better to wait for the processing result.
http://jira.cubrid.org/browse/CBRD-25690

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll discard the changes of this part.

Comment on lines 32 to 33
'a'
'b'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has been reported as a bug. It would be better to wait for the processing result.
http://jira.cubrid.org/browse/CBRD-25750

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert back.

===================================================

null


c
b
'b'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has been reported as a bug. It would be better to wait for the processing result.
http://jira.cubrid.org/browse/CBRD-25750

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert back.

@@ -66,7 +66,7 @@ null


k
b
'b'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has been reported as a bug. It would be better to wait for the processing result.
http://jira.cubrid.org/browse/CBRD-25750

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert back.

@@ -94,7 +94,7 @@ expression
null


+12345
' +12345'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has been reported as a bug. It would be better to wait for the processing result.
http://jira.cubrid.org/browse/CBRD-25750

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert back.

@@ -157,7 +157,7 @@ null


a
1
'1'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has been reported as a bug. It would be better to wait for the processing result.
http://jira.cubrid.org/browse/CBRD-25750

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert back.

@kimhak-tech
Copy link
Contributor Author

I finish the modification based on the comment.

@tw-kang tw-kang requested a review from ssihil December 23, 2024 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants