Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DII_Packet-s are not Num-eric. #52

Merged
merged 1 commit into from
Jul 3, 2024
Merged

DII_Packet-s are not Num-eric. #52

merged 1 commit into from
Jul 3, 2024

Conversation

nwf-msr
Copy link
Contributor

@nwf-msr nwf-msr commented Jul 3, 2024

The fromInteger pun here is not used in practice in favor of the diiInstruction pattern.

@nwf-msr
DII_Packet-s are not Num-eric.
c6b72b6 
The `fromInteger` pun here is not used in practice in favor of the
diiInstruction pattern.
marnovandermaas
marnovandermaas approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@marnovandermaas marnovandermaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me and the build doesn't seem to mind not having this Num instance.

@PeterRugg PeterRugg merged commit 52a4e6e into CTSRD-CHERI:master Jul 3, 2024
2 checks passed
@nwf-msr nwf-msr deleted the 202406-dii-not-num branch July 4, 2024 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marnovandermaas marnovandermaas marnovandermaas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nwf-msr @marnovandermaas @PeterRugg